Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84958
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.44 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <5504B69C.2070903@lerdorf.com>
References: <CAFMT4NoOoAoCDKwv4JWxpjrBggTXs=TPKPKGmPa=zD1YQ=sSZg@mail.gmail.com>
	<CAB6YZuy=A51oZhkcWGThFLu8sem-DSVQBYQcZR0ovsaRRdotyQ@mail.gmail.com>
	<BLU436-SMTP46A6B624FEB7482D63AA7CE2040@phx.gbl>
	<CABDNdAFjMW4cmSwUr741akwToSxoRjLdB0t5+WJ-hpW9jBwM4w@mail.gmail.com>
	<5504B69C.2070903@lerdorf.com>
Date: Sun, 15 Mar 2015 18:16:42 -0600
Message-ID: <CAFMT4Nryo929YVG54wWxacU2-TtcfVeXEM2ZHmN4X6yTSqRq=Q@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Philip Sturgeon <pjsturgeon@gmail.com>, Bob Weinand <bobwei9@hotmail.com>, 
	=?UTF-8?Q?Pavel_Kou=C5=99il?= <pajousek@gmail.com>, 
	internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC][PRE-VOTE] Reserving More Types in PHP 7
From: levim@php.net (Levi Morrison)

On Sat, Mar 14, 2015 at 4:30 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> On 03/15/2015 07:31 AM, Philip Sturgeon wrote:
>> On Sat, Mar 14, 2015 at 7:38 AM, Bob Weinand <bobwei9@hotmail.com> wrote=
:
>>>> Am 14.03.2015 um 10:21 schrieb Pavel Kou=C5=99il <pajousek@gmail.com>:
>>>>
>>>> On Saturday, March 14, 2015, Levi Morrison <levim@php.net> wrote:
>>>>> RFC Link: https://wiki.php.net/rfc/reserve_more_types_in_php_7
>>>>>
>>>>> The proposal has changed from the original. It no longer reserves the
>>>>> aliases out of the interest of reserving the smallest useful,
>>>>> uncontroversial subset. Some people want to remove aliases for these
>>>>> types so in the interest of being as uncontroversial as possible I am
>>>>> no longer proposing to remove them.
>>>>>
>>>>> This will go into voting on March 15th unless something comes up
>>>>> between now and then to persuade me otherwise.
>>>>>
>>>>> --
>>>>> PHP Internals - PHP Runtime Development Mailing List
>>>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>>>
>>>>>
>>>>
>>>> Hello,
>>>>
>>>> why do you consider a "true" and "false" as a type? It's not a type. i=
t's a
>>>> value?
>>>>
>>>> Regards
>>>> Pavel Kouril
>>>
>>> These aren't types. But useful for e.g. union types (int|false). [By th=
e way they're internally handled as different types=E2=80=A6 but that's an =
implementation detail=E2=80=A6]
>>>
>>> Also, he doesn't call them anywhere types, it's just the title.
>>>
>>> Bob
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>
>> This is a solid plan. Vote this and everyone should +1 it, so if this
>> scalar squabble results in a a 0-0-0 score we can at least add scalars
>> later.
>
> This is not quite that obvious I don't think. If
> https://wiki.php.net/rfc/context_sensitive_lexer isn't ready in time for
> 7.0 and we don't need to reserve these for one of the STH RFCs then we
> should hold off and do it alongside the context sensitive lexer change
> or we are going to needlessly break a ton of code including Drupal8:
>
>
> https://github.com/drupal/drupal/blob/8.0.x/core/lib/Drupal/Component/Uti=
lity/String.php#L15

Rasmus (and others),

How would you feel about emitting E_DEPRECATED whenever one of
these[1] names is used for a class declaration? Emitting E_DEPRECATED
is less helpful but less painful. It's not my preference (just like
emitting E_DEPRECATED for PHP 4 constructors was not my preference)
but ultimately I care about the eventual result. I'm happy to wait as
long as we've agreed to fix it eventually.

Of course, if a scalar types RFC passes most of these will be reserved
anyway. Right now it is a coin toss if Anthony's proposal will pass
(it keeps flipping back and forth).

  [1] int, float, bool, string, true, false, null