Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:84797 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10450 invoked from network); 15 Mar 2015 02:17:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Mar 2015 02:17:44 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.181 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.214.181 mail-ob0-f181.google.com Received: from [209.85.214.181] ([209.85.214.181:34869] helo=mail-ob0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F1/91-01144-7CBE4055 for ; Sat, 14 Mar 2015 21:17:43 -0500 Received: by obfv9 with SMTP id v9so13975915obf.2 for ; Sat, 14 Mar 2015 19:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ZOLcXQV3XGFy2WQ5E+LMobal8QOpKervoYzxMHrPk7s=; b=K6h/GXLHjUoWvmgcDcmt4j4GSQW5Vz8kmHE1qJyBBl9AWVMFxhZh/Nx/1Y2SIYZxaV MCvSSe3I9AF7+DR15ncGqRmZm6tNsUm/t8LfIZbUSt04wpbSXQj3OPU1gE+eKBr74i+b auI3zxRIY2nykISDvU6NWd50CyYHOS/oywljhxhQGL1IfV1ykOkkAqDmNpPG7vuEXE5g u1NbCquwQYyd6v3zZi+1n44/dmfbO+xqzvX6H1jYuqBV8hbkqliNDhfzh5IJYpV9qsTl pKJpOQMYqNebiKlm/l5/BLB9jZE9TR1LUR+xLAoKbNWJ21cIAmL81y1zeOaJa0aV9cFo w16Q== X-Received: by 10.60.103.116 with SMTP id fv20mr43939620oeb.2.1426385860721; Sat, 14 Mar 2015 19:17:40 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.202.58.2 with HTTP; Sat, 14 Mar 2015 19:17:00 -0700 (PDT) In-Reply-To: References: Date: Sun, 15 Mar 2015 11:17:00 +0900 X-Google-Sender-Auth: l5acY9H8v5kbjOEu1uzy7h2iX1c Message-ID: To: Scott Arciszewski Cc: "inter >> PHP internals" Content-Type: multipart/alternative; boundary=089e011606648a81b905114a567f Subject: Re: [PHP-DEV] [RFC] Timing-Safe Encoding Functions From: yohgaki@ohgaki.net (Yasuo Ohgaki) --089e011606648a81b905114a567f Content-Type: text/plain; charset=UTF-8 Hi Scott, On Sat, Mar 14, 2015 at 3:22 AM, Scott Arciszewski wrote: > https://wiki.php.net/rfc/timing_safe_encoding Nice to see this RFC. I haven't looked into patch yet, but no objections for the idea from me. Only concern is existing timing safe function name. i.e. hash_equals() http://php.net/manual/en/function.hash-equals.php This function is better to named hash_equal_ts() if we are trying to have consistent function names. (Old name should be alias, of course) Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --089e011606648a81b905114a567f--