Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:84773 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40098 invoked from network); 14 Mar 2015 12:06:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Mar 2015 12:06:07 -0000 Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.174 as permitted sender) X-PHP-List-Original-Sender: xinchen.h@zend.com X-Host-Fingerprint: 209.85.217.174 mail-lb0-f174.google.com Received: from [209.85.217.174] ([209.85.217.174:36043] helo=mail-lb0-f174.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F0/C1-29409-E2424055 for ; Sat, 14 Mar 2015 07:06:06 -0500 Received: by lbcds1 with SMTP id ds1so5381477lbc.3 for ; Sat, 14 Mar 2015 05:06:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=f1RwsHSdSJkVUqP0jsPWQIuii1XIeWWH/qo98QnTWyU=; b=isR61YJY3/nsYkcf0Ttw/hlzawvFi1o+AfzBmCxBKKm1Ft78LWjtGlgTKi34JVPLM8 RCd21CTdoc7KSJGH8m7c5fbjTI4f2tf6kYvXqvOEp5U2VNtA6R03+vmw/GGzAR46TdlB TmPvG+a6X5keD1XucqmtPCub9y5X5ufHcMp5EGnpGdshvVfki8oO+VIHCmMAMqcQt3rg NzHslxqP8h4fIPpnmKR+Al/NzLsNk/PZBdcq/QQpGIeBzoF+252ze3Zn0oV8kfbhEt0I 29V57c8c1EGp0fVoRIupY6tLxttVSJrPyRWgvC7AQ+34bCHKM9H8JWqKVrgvYp14ZSNy 21Vw== X-Gm-Message-State: ALoCoQkDUODOMP5EgZaQCVn9gW7XdeHqVJI0mhvA4oNoXwZIONx+HTCNJsQJFVHkKn1W36t2H4j2VLdeMz7Rw8VTkZSiJxchLVLhf6lIHBnoZURl9HhFHvTwUCTypLXzO4x6vwcVNpOwC8xJQpOuKhYHFOpHpsHK6w== X-Received: by 10.152.22.1 with SMTP id z1mr35625975lae.114.1426334762172; Sat, 14 Mar 2015 05:06:02 -0700 (PDT) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPSA id ba13sm942980lab.45.2015.03.14.05.06.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Mar 2015 05:06:00 -0700 (PDT) Received: by lagg8 with SMTP id g8so8151490lag.1 for ; Sat, 14 Mar 2015 05:05:59 -0700 (PDT) X-Received: by 10.152.179.139 with SMTP id dg11mr41399183lac.28.1426334759725; Sat, 14 Mar 2015 05:05:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.114.82.99 with HTTP; Sat, 14 Mar 2015 05:05:39 -0700 (PDT) In-Reply-To: References: Date: Sat, 14 Mar 2015 20:05:39 +0800 Message-ID: To: Bob Weinand Cc: PHP Internals , Dmitry Stogov Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Drop Multiply VM kind support From: laruence@php.net (Xinchen Hui) Hey: On Sat, Mar 14, 2015 at 8:01 PM, Bob Weinand wrote: >> Am 13.03.2015 um 05:01 schrieb Xinchen Hui : >> >> Hey: >> >> We have CALL SWITCH GOTO vm kind supports for long time. >> >> And we use CALL for default. >> >> SWITCH GOTO seems useless now, and brings us some troubles while >> maintaining . >> >> And also could make some extension unable to work, like in phpdbg: >> >> PHPDBG_G(vmret) = execute_data->opline->handler(execute_data); >> >> >> So, maybe it's time for us to remove GOTO and SWITCH at all? >> >> thanks >> >> -- >> Xinchen Hui >> @Laruence >> http://www.laruence.com/ > > Not sure whether it's useless, I'm not exactly aware of the performance differences. > But we would have to add some proper build-time check for phpdbg whether we're in CALL mode or not. [when you're using phpdbg on that machine, you probably aren't in a high-performance production environment anyway.] > > (Like with a clean #error message etc.) > After the latest fix by Dmitry, there will be no need for that. because, if in non CALL mode, phpdbg won't be able to built anymore. thanks > Bob -- Xinchen Hui @Laruence http://www.laruence.com/