Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:84699 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70451 invoked from network); 13 Mar 2015 17:31:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Mar 2015 17:31:17 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@bof.de; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=php@bof.de; sender-id=pass Received-SPF: pass (pb1.pair.com: domain bof.de designates 80.242.145.70 as permitted sender) X-PHP-List-Original-Sender: php@bof.de X-Host-Fingerprint: 80.242.145.70 mars.intermailgate.com Received: from [80.242.145.70] ([80.242.145.70:42122] helo=mars.intermailgate.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5D/DC-32208-4EE13055 for ; Fri, 13 Mar 2015 12:31:17 -0500 Received: (qmail 1525 invoked by uid 1009); 13 Mar 2015 18:31:13 +0100 Received: from 209.85.216.181 by mars (envelope-from , uid 89) with qmail-scanner-1.25-st-qms (clamdscan: 0.96.2/20187. spamassassin: 3.3.1. perlscan: 1.25-st-qms. Clear:RC:1(209.85.216.181):. Processed in 0.263515 secs); 13 Mar 2015 17:31:13 -0000 X-Antivirus-MYDOMAIN-Mail-From: php@bof.de via mars X-Antivirus-MYDOMAIN: 1.25-st-qms (Clear:RC:1(209.85.216.181):. Processed in 0.263515 secs Process 1511) Received: from mail-qc0-f181.google.com (gmail@bof.de@209.85.216.181) by mars.intermailgate.com with RC4-SHA encrypted SMTP; 13 Mar 2015 18:31:13 +0100 Received: by qcvp6 with SMTP id p6so28354725qcv.1 for ; Fri, 13 Mar 2015 10:31:11 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.140.48.133 with SMTP id o5mr60493707qga.8.1426267871613; Fri, 13 Mar 2015 10:31:11 -0700 (PDT) Received: by 10.140.82.198 with HTTP; Fri, 13 Mar 2015 10:31:11 -0700 (PDT) Received: by 10.140.82.198 with HTTP; Fri, 13 Mar 2015 10:31:11 -0700 (PDT) In-Reply-To: References: <3961990.KljssxxPxS@rofl> <4426444.JgVMhxXZoq@rofl> <1846386.qXWODMQA5A@rofl> Date: Fri, 13 Mar 2015 18:31:11 +0100 Message-ID: To: Bostjan Skufca , internals Content-Type: multipart/alternative; boundary=001a11351808d79bc205112edd74 Subject: Re: [PHP-DEV] SAPI apache2handler + pipelined HTTP request core dumps From: php@bof.de (Patrick Schaaf) --001a11351808d79bc205112edd74 Content-Type: text/plain; charset=UTF-8 Am 13.03.2015 18:26 schrieb "Bostjan Skufca" : > > If we create unconditional php_server_context_cleanup() call at the beginning of php_request(), would that be out of order? Does it remove also all context-dependent configuration? That's exactly what my Minipatch (addition of "1 ||") is doing. The php_server_context_cleanup() does exactly one thing: set SG(server_context) to NULL. My minipatch makes the code basically ignore that in php_handler(). The problem I have is that I do not understand under which circumstances that other codepath would be needed, which attempts to run a subrequest in an already established and still active interpreter. The code must be there for a reason, but I don't know it... best regards Patrick --001a11351808d79bc205112edd74--