Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84673
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.53 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <ff8e8d5564b00b7baead3d9dd46282c8@mail.gmail.com>
References: <ff8e8d5564b00b7baead3d9dd46282c8@mail.gmail.com>
Date: Fri, 13 Mar 2015 18:56:28 +0900
Message-ID: <CAGa2bXbWykvJ9MdPG2LtycF0LA0Cp4XDZH6tW1MykDveXV_AOQ@mail.gmail.com>
To: Zeev Suraski <zeev@zend.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e015382b6187dfb05112886c2
Subject: Re: [PHP-DEV] [VOTE][RFC] Coercive Scalar Type Hints
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--089e015382b6187dfb05112886c2
Content-Type: text/plain; charset=UTF-8

Hi Zeev,

On Thu, Mar 12, 2015 at 12:10 AM, Zeev Suraski <zeev@zend.com> wrote:

> The latest version of the RFC includes changes discussed on internals@
> last
> week:
>
> 1.  Accept string->bool and int->bool conversions (false->bool is not
> supported)
>
> 2.  Accept leading/trailing spaces in string->number conversions.
>
>
>
> wiki.php.net/rfc/coercive_sth
>
> wiki.php.net/rfc/coercive_sth#vote
>

Status should be changed to "voting". It's "under discussion" now.

It's not nice to have 2 modes for new feature while we can do it in a
single mode.
BC matters, but cleaner and simpler design would bring more benefits for
both PHP
users and developers. There is enough time to adopt for users.

The default behavior is better with this RFC. Weak mode defined in other
RFC is too
weak to be useful while strict mode seems too restrictive.

e.g.
<?php
function check_num_range(int $num) { if ($num < 0 || $num > 100)
trigger_error('Invalid range'); }
// Somewhere far from function definition.
$num = $GET['num'];
// Somewhere far from $num definition.
check_num_range($num); // Trying to check validity, int and range.
echo 'You have '.$num. ' now <br />'; // But $num could have any string.
                                                            //
"check_num_range((int)$num)" wouldn't help also.
?>

If we decide to have even more stricter hint in the future, we may decide
to use "strict"
mode with this RFC. This is more preferable path for PHP being type aware.
IMHO.

For these reasons, I voted "yes" for this, "no" for the other.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--089e015382b6187dfb05112886c2--