Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84606
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLs9rd8bcQzoOQ8t465FYOfZvw2_HW=XS7OeofO+_qkOCg@mail.gmail.com>
References: <CA+9eiLs9rd8bcQzoOQ8t465FYOfZvw2_HW=XS7OeofO+_qkOCg@mail.gmail.com>
Date: Wed, 11 Mar 2015 19:01:05 -0700
Message-ID: <CADR=R-i8CwFHfuTCpZ56nR7vx9PxU+=kpcT1MJv6=geudwbNww@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>, Rasmus Lerdorf <rasmus@lerdorf.com>, 
	Nikita Popov <nikita.ppv@gmail.com>, Xinchen Hui <xinchen.h@zend.com>, Anatol Belski <ab@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134bd80b15e9705110dc1a5
Subject: Re: [PHP-DEV] Safe execution timeout handling
From: smalyshev@gmail.com (Stas Malyshev)

--001a1134bd80b15e9705110dc1a5
Content-Type: text/plain; charset=UTF-8

Hi!

> Instead of throwing zend_error() from signal handler, now we just set
> EG(vm_interrupt) and EG(timed_out) flags. PHP VM checks EG(vm_interrupt)
> flag on each JMPx instruction (potential loop iteration) and then throws

JMPs are not the only operations that can transfer control and thus
potentially form a loop.

> Unfortunately this approach doesn't support interruption of long-running
> internal functions yet. It should be extended in some way. May be
> additional timeout.

Doing additional setjmp when entering internal function probably would
be too expensive. So the question is how to get out of the bad function
without incurring per-function overhead... Not sure how to do it.

-- 
Stas Malyshev
smalyshev@gmail.com

--001a1134bd80b15e9705110dc1a5--