Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84577
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <e0d2f8ec318322c85d7d620869ec37f1@mail.gmail.com>
References: <BAY178-W5945DBF18D50C0F91C760DE190@phx.gbl>
	<76c47c6fbd961958c10bc1a069377a34@mail.gmail.com>
	<CAAyV7nG1FAVHxtmi=C1Lakm_AfrhSuqSH9+-hS5Xz5zOYTdegw@mail.gmail.com>
	<2d48b241e682e59df6ab876b42663628@mail.gmail.com>
	<alpine.DEB.2.11.1503112035520.5941@whisky.home.derickrethans.nl>
	<e0d2f8ec318322c85d7d620869ec37f1@mail.gmail.com>
Date: Wed, 11 Mar 2015 17:04:54 -0400
Message-ID: <CAAyV7nF+zDYJgPrm3zs1mxd=q_ASOqJvUwFEfnHyVtYHc4HC-A@mail.gmail.com>
To: Zeev Suraski <zeev@zend.com>
Cc: Derick Rethans <derick@php.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] RE: [VOTE][RFC] Coercive Scalar Type Hints
From: ircmaxell@gmail.com (Anthony Ferrara)

Zeev,

On Wed, Mar 11, 2015 at 4:50 PM, Zeev Suraski <zeev@zend.com> wrote:
>> -----Original Message-----
>> From: Derick Rethans [mailto:derick@php.net]
>> Sent: Wednesday, March 11, 2015 10:37 PM
>> To: Zeev Suraski
>> Cc: Anthony Ferrara; internals@lists.php.net
>> Subject: RE: [PHP-DEV] RE: [VOTE][RFC] Coercive Scalar Type Hints
>>
>> > You're right, sorry.  Reverse it then:
>> > function bar(int $x)
>> > $foo = 1.0;
>> > bar($foo);  // will definitely fail in strict mode
>>
>> And it should fail, as logically it is the same as:
>>
>> $foo = 1.901 - 0.709 - 0.192;
>> bar($foo);
>>
>> which is only 1, if you look at it with a small enough precision.
>
> I'm not sure what you're trying to say.  The two pieces are indeed
> identical from all points of view - static analysis, how it would behave
> in strict type hinting, weak type hinting or coercive type hinting.

I think Derick's point is more that: http://3v4l.org/b4S8d

var_dump($foo); gives float(1) while it is != 1 (even loose).

So debugging is weird, since it looks like it should work (hey, it
says float(1), why isn't it passing for an int?). In strict mode, it's
an error because it's a float.

So it's not quite identical. Since logically it should work under your
rules, but it doesn't work. And there's nothing to the user that
implies or confirms that it shouldn't work.

Anthony