Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84571
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.212.176 as permitted sender)
References: <BAY178-W5945DBF18D50C0F91C760DE190@phx.gbl>	<76c47c6fbd961958c10bc1a069377a34@mail.gmail.com>
 <CAAyV7nG1FAVHxtmi=C1Lakm_AfrhSuqSH9+-hS5Xz5zOYTdegw@mail.gmail.com>
In-Reply-To: <CAAyV7nG1FAVHxtmi=C1Lakm_AfrhSuqSH9+-hS5Xz5zOYTdegw@mail.gmail.com>
MIME-Version: 1.0
Thread-Index: AQD1YWXqQx6MzBD1VX0WwX4EEwdHWAHgk7pSAio5GUyerT7xcA==
Date: Wed, 11 Mar 2015 20:53:24 +0200
Message-ID: <2d48b241e682e59df6ab876b42663628@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: RE: [PHP-DEV] RE: [VOTE][RFC] Coercive Scalar Type Hints
From: zeev@zend.com (Zeev Suraski)

> -----Original Message-----
> From: Anthony Ferrara [mailto:ircmaxell@gmail.com]
> Sent: Wednesday, March 11, 2015 8:28 PM
> To: Zeev Suraski
> Cc: Theodore Brown; internals@lists.php.net
> Subject: Re: [PHP-DEV] RE: [VOTE][RFC] Coercive Scalar Type Hints
>
> Zeev,
>
> >> You also stated above that false->bool is not supported (I'm guessing
> > you
> >> meant float->bool). So users would be able to pass "4.3" to a bool
> > typehint,
> >> but not 4.3? This behavior seems very arbitrary and confusing.
> >
> > It may be confusing, but only academically so.  Again, this approach
> > tries to work well with real world usage - and reject conversions
> > which are likely to be erroneous.  "4.3" may look like a floating
> > point number but in the context of conversion to boolean, that doesn't
> > matter much.  It's a string.
>
> Doesn't that contradict what you've been saying the whole time about how
> "13" and 13 and 13.0 are really "the same thing", and as such should be
> coerced?

No, it does not.  "13" and 13 and 13.0 are the same thing when you're
expecting an integer, and rejecting "13" as an integer is nothing but noise
in the vast majority of cases - noise that will push towards an explicit
cast.  Strings, however, are treated in a totally different way that places
zero meaning on their numeric value across the entirety of PHP when in the
context of a boolean.

>
> > function bar(float $x)
> > $foo = 1;
> > bar($foo);  // will definitely fail in strict mode
>
> No, actually it won't fail in strict mode:
> https://wiki.php.net/rfc/scalar_type_hints_v5#integers_should_be_accepted
> _for_strict_float_arguments

You're right, sorry.  Reverse it then:
function bar(int $x)
$foo = 1.0;
bar($foo);  // will definitely fail in strict mode

Zeev