Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84459
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender)
Date: Mon, 9 Mar 2015 10:35:34 +0000 (GMT)
To: Trevor Suarez <rican7@gmail.com>
cc: PHP internals <internals@lists.php.net>
In-Reply-To: <CAHXmDMD3zwMiF0G-VjoyP6BP+rtfV41=nt11GZOWryHFka8g0g@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1503091031270.5941@whisky.home.derickrethans.nl>
References: <CAHXmDMD3zwMiF0G-VjoyP6BP+rtfV41=nt11GZOWryHFka8g0g@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] [PR] DateTime::createFromImmutable() method
From: derick@php.net (Derick Rethans)

On Thu, 5 Mar 2015, Trevor Suarez wrote:

> Good morning internals!
> 
> I would like to propose a small addition be made to the DateTime class.
> 
> https://github.com/php/php-src/pull/1145

When the factory method was added, we had this same discussion. And the 
discussions lead to the conclusion that it does not make sense to have 
this "createFromImmutable" factory method on DateTime. Basically with 
the same reasons that people should type hint against the Interface 
instead. To emulate that in PHP 5.5 and lower, users can just do:

class DateTimeInterface extends DateTime {}

I know, that's a bit of a hack.

I am against this addition, even though the patch looks OK.

cheers,
Derick