Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84419
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.41 as permitted sender)
User-Agent: K-9 Mail for Android
In-Reply-To: <CAGa2bXZqw5LAHcBUQ7_Wkkh7BJHdM7ns4X3xTTkdEzLFy2Dt-g@mail.gmail.com>
References: <CAGa2bXai0cXrqeq3X2vTV8CjseAp=CUY29YaaxKniZENw0-x4g@mail.gmail.com> <op.xuxm3hojhuszwh@tsukapiou> <CAGa2bXbiQw82=+cGPurRwTnsD31MaZ9mM_e3WWLNPgcNz+H5zg@mail.gmail.com> <54F83061.60108@seld.be> <CAGa2bXaNcHvSAnLtFkUnLwWwYeXbrQptjqUPpOPBHXCc2_Vs6w@mail.gmail.com> <54FB44EE.6000704@gmail.com> <CAGa2bXZqw5LAHcBUQ7_Wkkh7BJHdM7ns4X3xTTkdEzLFy2Dt-g@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain;
 charset=UTF-8
Date: Sat, 07 Mar 2015 23:31:43 +0000
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
CC: "internals@lists.php.net" <internals@lists.php.net>
Message-ID: <6805F3C6-E73F-4A00-A94A-FE38B7E6D90F@gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] [DISCUSSION] Consistent Function Names
From: rowan.collins@gmail.com (Rowan Collins)

On 7 March 2015 22:47:48 GMT, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>Hi Rowan,
>
>On Sun, Mar 8, 2015 at 3:35 AM, Rowan Collins <rowan.collins@gmail.com>
>wrote:
>
>> On 06/03/2015 23:03, Yasuo Ohgaki wrote:
>>
>>> We have a lot of array_u*() functions such as
>>>
>>> http://php.net/manual/en/function.array-uintersect-uassoc.php
>>> array array_uintersect_uassoc ( array $array1 , array $array2 [,
>array
>>> $...
>>> ], callable $value_compare_func , callable $key_compare_func )
>>> this can be consolidated to
>>> http://php.net/manual/en/function.array-intersect-assoc.php
>>> array array_intersect_assoc ( array $array1 , array $array2 [, array
>$...
>>> ]
>>> )
>>>
>>> All of these has callback the end of parameters. These may be
>>> consolidated.
>>> I'll add this to the RFC if this is preferred.
>>>
>>
>> Those functions both take any number of arguments, so given a
>function
>> call with 4 arguments, you can't know if that's 4 arrays, or 2 arrays
>and 2
>> callbacks. Don't forget that array($class_name, $method_name) is a
>valid
>> callback, so you can't judge it by the type of the arguments either.
>
>
>Thank you for heads up. If I detect array($class_name, $method_name) as
>callback, there could
>be unintended callback calls.
>
>Since we have been deprecated similar
>call_user_method()/call_user_method_array(), we may
>deprecate array callbacks for u* functions, then consolidate in the
>future,
>perhaps PHP8.
>I don't mind add this to the RFC.

What? That's not the same thing at all. I'm pretty sure those functions are deprecated *because* we have array callback forms, so you can use call_user_func to call a method.

PHP has a well-defined definition of "callable", as used by is_callable() and function parameter typehints, and literally everywhere that wants a callback. Since there's no such thing as a function or method pointer, that definition includes a string identifying a plain function, and two array forms, [string, string] and [object, string], representing static and instance methods, respectively. You can't not accept those forms as a callback parameter in one particular function just to make things tidier.

Regards,
-- 
Rowan Collins
[IMSoP]