Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84384
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.169 as permitted sender)
MIME-Version: 1.0
References: <E4EDB8A3-20DD-4DB9-AEB8-581B42222628@ajf.me> <CABBJUpedHeCArT+8YqUv906vQSbWJ_hvcjgbg-J5CNYZQhyHUg@mail.gmail.com>
 <A94D26CE-48FE-4642-94BF-330D4A43D925@ajf.me> <CAGAGxbYG_0r1Kc5dY0AqY-c3Ng0pg-DZWoXdkQN4kBxZd2y7CA@mail.gmail.com>
 <D40953EF-A733-4D8B-A310-1E8290746AFC@ajf.me>
Date: Fri, 06 Mar 2015 15:41:35 +0000
Message-ID: <CACwt+JegfRAh=T+TTXv-dHX81tyaYFb29dMoyVNatW4fU-rF7w@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>, Chris Wright <cw@daverandom.com>
Cc: Xinchen Hui <laruence@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d04388df103c6590510a08566
Subject: Re: [PHP-DEV] Make zend_parse_parameters emit E_RECOVERABLE_ERROR
From: patrickallaert@php.net (Patrick ALLAERT)

--f46d04388df103c6590510a08566
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Le lun. 1 sept. 2014 =C3=A0 20:13, Andrea Faulds <ajf@ajf.me> a =C3=A9crit =
:

>
> On 1 Sep 2014, at 17:29, Chris Wright <cw@daverandom.com> wrote:
>
> > It's also worth noting that the "return NULL on zpp failure"
> > convention is not followed to the letter, I have seen places that
> > RETURN_FALSE - I can't remember exactly where I have seen this but I
> > will dig a ref out if anyone wants it.
>
> Good point. This is also, it has to be said, quite rarely documented. I=
=E2=80=99m
> not sure we even document zip=E2=80=99s behaviour anywhere in the manual,=
 which
> means users don=E2=80=99t know what to expect.
>
> >> To help BC, we could even make it do the old thing if @ is being used
> to silence it.
> >
> > Don't like this
>
> I=E2=80=99m not sure I do either, it=E2=80=99s merely a suggestion if it =
would help BC,
> but it probably not a good idea, as @ should only suppress errors, not
> change behaviour.
>
> > I'm roughly -0.5 on this proposal overall. I'd like this to be easily
> > handleable in userland, but I don't like E_RECOVERABLE_ERROR (in
> > general, not just here). I'd very much support this if it used
> > exceptions, though.
>
> Perhaps this could be postponed until Nikita Popov can revive his
> Exceptions in the Engine RFC. If that were to pass, I could make an RFC f=
or
> this.
> --
> Andrea Faulds
> http://ajf.me/


I don't have an opinion yet as I have to think a bit more about it.

I have the impression that giving the user to bail out on specific error
levels would be less intrusive as he would be able to opt-in for it. See
the "Pedantic errors (Was: Re: [PHP-DEV] [RFC][VOTE] Improve array to
string conversion)" thread. I would be glad to gather some opinions to see
if it is worth investigating.

Cheers,
Patrick

--f46d04388df103c6590510a08566--