Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84374
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU5TbFWnu6D5gmCzdoQyL=BQ9_8HF5Sn-erWm7zfFv0sMg@mail.gmail.com>
References: <CABBJUpfhGtB2JPA7VS1c5Syw0OcZyTp--rnA+qCaiCjpxDCDtg@mail.gmail.com>
 <CAEZPtU5TbFWnu6D5gmCzdoQyL=BQ9_8HF5Sn-erWm7zfFv0sMg@mail.gmail.com>
Date: Fri, 6 Mar 2015 11:02:50 +0800
Message-ID: <CABBJUpexFXBJxK8DcmpntRhiWzq_VwbbwDrtNq7RbYRmMgTN9g@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Enable Zend Signals Handler By Default
From: laruence@php.net (Xinchen Hui)

On Fri, Mar 6, 2015 at 6:31 AM, Pierre Joye <pierre.php@gmail.com> wrote:
> On Thu, Mar 5, 2015 at 5:27 AM, Xinchen Hui <laruence@php.net> wrote:
>> Hey internal:
>>
>>
>>     There is also a problem we have been suffering from for a quite
>> long time, that is signal raised at OOM/Timeout when execution is in a
>> critical area will lead PHP crash or even more big troubles if it is
>> in shared memory.
>>
>>      You may still remember we disabled zend signal handlers before
>> PHP-5.4 was released because it doesn't work well as mod_apache. which
>> is described in #61083.
>>
>>      Zend signal is a good way to fix the problem, thus I did some
>> research then fixed zend signals(make it works with apache2handler),
>> committed in https://github.com/php/php-src/commit/fd5a756ad44124ffa7e9a5810a31ff49e91708cf
>>
>>      And no obviously performance affects in reallife app(benched with
>> wordpress).
>>
>>      Next, We may do some further optimizationes based on that.
>>
>>      For now, I want to make zend signals handler enable by default
>> (in configure) for PHP7, or maybe totally removed the
>> --enable-zend-signals option?   thus make zend_signal.c always be
>> compiled and linked.
>>
>>      Is there any concerns or objections on this?
>
> Generally speaking no, but I would be very careful about the
> portability parts here, and not only about windows.
Here is the problem, if --enable-zend-signals == no

then the whole zend-signals won't be compiled and linked..

I am going to do it in another way. always compile it. but let's make
--enable-zend-sgianls means use or not use.

thanks
>
> I would go in two steps, first enable it by default and see which
> issues exist on the various supported platforms then once everything
> is ready, we can consider removing the setting. But removing it
> straight away may force users to simply do not use 7 anymore until
> things are fixed, if necessary.
>
>
> --
> Pierre
>
> @pierrejoye | http://www.libgd.org



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/