Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:84339 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39985 invoked from network); 5 Mar 2015 13:28:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Mar 2015 13:28:14 -0000 Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.44 as permitted sender) X-PHP-List-Original-Sender: xinchen.h@zend.com X-Host-Fingerprint: 209.85.215.44 mail-la0-f44.google.com Received: from [209.85.215.44] ([209.85.215.44:36143] helo=mail-la0-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DD/C3-18504-AE958F45 for ; Thu, 05 Mar 2015 08:28:11 -0500 Received: by labgd6 with SMTP id gd6so4331502lab.3 for ; Thu, 05 Mar 2015 05:28:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=2/aBP+tka3YcBqauMmiTPut8ThDAF/s+zMwJLgHawSg=; b=HhyymxWA/ibHjU3mlh8bWvDRTE7BK0H87sbSPC4Ybjukh6Hk1nhdV3bUffnxvFa0yo PuabTeKz/fTn6a64D4kF68iVK4H45Efa/8OZRP0AtlI5FzSZGS9cPTIIM1dMSyr9WorM 3LyggsBobiuTBLO1yTDYgBHiLdwDZQNvgEElKPTts49uPDfRISV4Mb4NEdyooslg+LFZ Y+7u5Q/Wr0oz76XhggNLjN+/EzSO9eMI4AoXXPe/WUDpIntm5yztNBMImM9q3Rf0RTE1 QoZfJzpfr5NbsUk5ySduwbBjpj+rNjE4tyPB4S36dMlSagk+S7MXmERN/wt0OMTDP66r zFLA== X-Gm-Message-State: ALoCoQm+vNP6ldEb3IDmyGDeoxeVO1VAvEX6WqIrMmv4+8MLRZTMIRcpFRpGaZn8xr1zWR4EjY0UYxIvsXZDJNq+dJabmI1HXyS6Ucy6JGcNkChfPRfgGLuZWGNgCEHMNifTnyfB4311+lvMpJBcGOpeVAK8PS9/QA== X-Received: by 10.112.181.231 with SMTP id dz7mr7537859lbc.47.1425562087106; Thu, 05 Mar 2015 05:28:07 -0800 (PST) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPSA id x5sm1200001laa.44.2015.03.05.05.28.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2015 05:28:06 -0800 (PST) Received: by labgf13 with SMTP id gf13so26794352lab.10 for ; Thu, 05 Mar 2015 05:28:05 -0800 (PST) X-Received: by 10.152.42.238 with SMTP id r14mr7942825lal.13.1425562085062; Thu, 05 Mar 2015 05:28:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.82.99 with HTTP; Thu, 5 Mar 2015 05:27:44 -0800 (PST) Date: Thu, 5 Mar 2015 21:27:44 +0800 Message-ID: To: PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Enable Zend Signals Handler By Default From: laruence@php.net (Xinchen Hui) Hey internal: There is also a problem we have been suffering from for a quite long time, that is signal raised at OOM/Timeout when execution is in a critical area will lead PHP crash or even more big troubles if it is in shared memory. You may still remember we disabled zend signal handlers before PHP-5.4 was released because it doesn't work well as mod_apache. which is described in #61083. Zend signal is a good way to fix the problem, thus I did some research then fixed zend signals(make it works with apache2handler), committed in https://github.com/php/php-src/commit/fd5a756ad44124ffa7e9a5810a31ff49e91708cf And no obviously performance affects in reallife app(benched with wordpress). Next, We may do some further optimizationes based on that. For now, I want to make zend signals handler enable by default (in configure) for PHP7, or maybe totally removed the --enable-zend-signals option? thus make zend_signal.c always be compiled and linked. Is there any concerns or objections on this? thanks -- Xinchen Hui @Laruence http://www.laruence.com/