Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84323
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.161 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbiQw82=+cGPurRwTnsD31MaZ9mM_e3WWLNPgcNz+H5zg@mail.gmail.com>
References: <CAGa2bXai0cXrqeq3X2vTV8CjseAp=CUY29YaaxKniZENw0-x4g@mail.gmail.com>
	<op.xuxm3hojhuszwh@tsukapiou>
	<CAGa2bXbiQw82=+cGPurRwTnsD31MaZ9mM_e3WWLNPgcNz+H5zg@mail.gmail.com>
Date: Thu, 5 Mar 2015 09:29:36 +0100
Message-ID: <CANUQDCh4VGqHLuixRAHn42dGJ52yuhbkV-4_JyBntqsDgmm6Cg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Benoit Schildknecht <bensor987@neuf.fr>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b8750803decba0510865ed5
Subject: Re: [PHP-DEV] Re: [RFC] [DISCUSSION] Consistent Function Names
From: me@kelunik.com (Niklas Keller)

--047d7b8750803decba0510865ed5
Content-Type: text/plain; charset=UTF-8

If we introduce those new aliases, it should be clearly stated in the docs
which function should be used, maybe we can remove the old one in the far
future then. But the more important point is, that it's not that confusing
to users. Which one should I use? Why's there another one? We already have
that situation with `count` and `sizeof`.

Regards, Niklas

2015-03-05 9:07 GMT+01:00 Yasuo Ohgaki <yohgaki@ohgaki.net>:

> Hi Benoit,
>
> On Wed, Mar 4, 2015 at 2:34 AM, Benoit Schildknecht <bensor987@neuf.fr>
> wrote:
>
> > I think the new functions must have consistent parameters order too. I
> > think it is about the right time, so we'll have a cleaner and more
> logical
> > language.
> >
> > ATM, it's a real headache, we constantly have to read the documentation
> to
> > make sure we give the arguments in the right order.
> >
> > For instance
> > - implode() : "implode() can, for historical reasons, accept its
> > parameters in either order. "
> > - strpos( $haystack, $needle )
> > - in_array( $needle, $haystack )
> >
>
> $needle should be 2nd argument like
>
> int strpos  ( string $haystack  , mixed $needle  [, int $offset= 0  ] )
> string stristr ( string $haystack , mixed $needle [, bool $before_needle =
> false ] )
>
> Rasmus suggested to have IEEE 1003.1 compliance. I like the idea and I'll
> add
> this in the RFC, probably. These are the order of parameters.
>
> So array functions are subject to be changed.
>
> bool in_array  ( mixed $needle  , array $haystack  [, bool $strict  ] )
> Renamed to array_in() and fix order.
>
> mixed array_search  ( mixed $needle  , array $haystack  [, bool $strict  ]
> )
> Renamed to array_find() and fix order.
>
> bool array_key_exists ( mixed $key , array $array )
> Renamed to array_key_find() and fix order.
>
> array array_keys ( array $array [, mixed $search_value [, bool $strict =
> false ]] )
> OK as it is now.
>
> implode() may be changed to have
> string implode ( string $glue , array $pieces )
> always.
>
> If there are missing functions, please let me know.
> I'll try to address.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

--047d7b8750803decba0510865ed5--