Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84322
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.48 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <op.xuxm3hojhuszwh@tsukapiou>
References: <CAGa2bXai0cXrqeq3X2vTV8CjseAp=CUY29YaaxKniZENw0-x4g@mail.gmail.com>
 <op.xuxm3hojhuszwh@tsukapiou>
Date: Thu, 5 Mar 2015 17:07:19 +0900
Message-ID: <CAGa2bXbiQw82=+cGPurRwTnsD31MaZ9mM_e3WWLNPgcNz+H5zg@mail.gmail.com>
To: Benoit Schildknecht <bensor987@neuf.fr>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c131f6eea15405108610a1
Subject: Re: [PHP-DEV] Re: [RFC] [DISCUSSION] Consistent Function Names
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c131f6eea15405108610a1
Content-Type: text/plain; charset=UTF-8

Hi Benoit,

On Wed, Mar 4, 2015 at 2:34 AM, Benoit Schildknecht <bensor987@neuf.fr>
wrote:

> I think the new functions must have consistent parameters order too. I
> think it is about the right time, so we'll have a cleaner and more logical
> language.
>
> ATM, it's a real headache, we constantly have to read the documentation to
> make sure we give the arguments in the right order.
>
> For instance
> - implode() : "implode() can, for historical reasons, accept its
> parameters in either order. "
> - strpos( $haystack, $needle )
> - in_array( $needle, $haystack )
>

$needle should be 2nd argument like

int strpos  ( string $haystack  , mixed $needle  [, int $offset= 0  ] )
string stristr ( string $haystack , mixed $needle [, bool $before_needle =
false ] )

Rasmus suggested to have IEEE 1003.1 compliance. I like the idea and I'll
add
this in the RFC, probably. These are the order of parameters.

So array functions are subject to be changed.

bool in_array  ( mixed $needle  , array $haystack  [, bool $strict  ] )
Renamed to array_in() and fix order.

mixed array_search  ( mixed $needle  , array $haystack  [, bool $strict  ] )
Renamed to array_find() and fix order.

bool array_key_exists ( mixed $key , array $array )
Renamed to array_key_find() and fix order.

array array_keys ( array $array [, mixed $search_value [, bool $strict =
false ]] )
OK as it is now.

implode() may be changed to have
string implode ( string $glue , array $pieces )
always.

If there are missing functions, please let me know.
I'll try to address.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c131f6eea15405108610a1--