Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84236
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 74.125.82.169 as permitted sender)
References: <CABBJUpd8f8ApcPqJp6d5ih0Bywkk4LUnFdQOD=ovL1U6nhid0Q@mail.gmail.com>
 <CABBJUpf63s3_Yp2o2_YdWYZJKVPqVTR+94qXmZUU7R5=8NiJrQ@mail.gmail.com>
 <BLU437-SMTP88BCE6F234A85E87BA3F4BE2150@phx.gbl> <CABBJUpcD5MTHYc8UVi-=MpXs3U-pAb0KcZVj0nXJiu_SdOqQBg@mail.gmail.com>
 <BLU436-SMTP2039471E714BB553BE06CC8E2150@phx.gbl> <CA+9eiLvb-_5TzW8-_Sguxa0JmqtuAT21A7jkydV4-6z-w1-EaA@mail.gmail.com>
 <CAMUwpuQBn0GY98BSXc8o3d2U6K+nDts7ZA8ZP4X_-r81due5Mg@mail.gmail.com>
In-Reply-To: <CAMUwpuQBn0GY98BSXc8o3d2U6K+nDts7ZA8ZP4X_-r81due5Mg@mail.gmail.com>
MIME-Version: 1.0
Thread-Index: AQD4C3IYZ8ixidYeCJVBHrwVMMzwcQKM7Vi6APWEoLUCBfYYjQG30wCdAthkrE0CmeEoaJ5VxNzg
Date: Tue, 3 Mar 2015 15:52:18 +0200
Message-ID: <246f14640403edad07e8d595fd357286@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: RE: [PHP-DEV] Re: About optimization for compiler
From: zeev@zend.com (Zeev Suraski)

> -----Original Message-----
> From: julienpauli@gmail.com [mailto:julienpauli@gmail.com] On Behalf Of
> Julien Pauli
> Sent: Monday, March 02, 2015 9:07 PM
> To: Dmitry Stogov
> Cc: Bob Weinand; Xinchen Hui; PHP Internals
> Subject: Re: [PHP-DEV] Re: About optimization for compiler
>
> As OPCache is nowadays not compatible at all with PHP7 (development has
> not started yet, or I'm not aware of it) , why not merge OPCache to PHP7
> source tree (when the time for this will come), still as an extension at
> first
> time, and keep developing optimizer passes into this (aka : not in Zend/)
> ?

It's a bit OT, but can you explain what you mean here?  OPcache works with
the current master (PHP 7), and actually, OPcache worked with phpng all
along and definitely since it was merged into master...  It's been
integrated to the php-src tree since it became standard in 5.5.  Do you mean
the standalone github repos for older versions?

> I'm also +1 to keep our optimizations into OPCache (into an extension),

I'm slightly confused - you mean keep it in (or move optimization over to)
the OPcache extension, or move it into its own extension?
If it's the former, then I agree.  Optimization passes and opcode caching
are very much linked, as performing optimizations without having an opcode
cache rarely makes sense.

> and
> allow them to be disabled (like its the case actually), because this
> subject is
> very hot and sensible.
>
> We should keep a PHP compiler as-is, and move optimization passes away
> from it. zend_extension_op_array_handler() callback is designed for that
> purpose.

Agreed.

Zeev