Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84166
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.45 as permitted sender)
MIME-Version: 1.0
References: <CACwt+JehH4LcPtiG+8UKUP+nek8eA=idmnwo5QPhhAL5VrUvQQ@mail.gmail.com>
Date: Mon, 02 Mar 2015 12:46:29 +0000
Message-ID: <CACwt+JdVvGty999vfQeFP4p1SN_P4V7pBLvvgoR4JDhQiDguLA@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>, francois@php.net
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11336254748ae805104d9bb5
Subject: Re: [PHP-DEV] [RFC][VOTE] Improve array to string conversion
From: patrickallaert@php.net (Patrick ALLAERT)

--001a11336254748ae805104d9bb5
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Le lun. 2 mars 2015 =C3=A0 13:39, Patrick ALLAERT <patrickallaert@php.net> =
a
=C3=A9crit :

> Le mer. 25 f=C3=A9vr. 2015 =C3=A0 12:16, Xinchen Hui <laruence@php.net> a=
 =C3=A9crit :
>
> Hey:
>>
>> On Tue, Feb 24, 2015 at 12:06 AM, Fran=C3=A7ois Laupretre <francois@php.=
net>
>> wrote:
>> > Hi,
>> >
>> > Starting the vote for https://wiki.php.net/rfc/array-to-string.
>> >
>> > Please note that, while the initial RFC proposed both options of eithe=
r
>> > fully supporting the feature, or disabling it, the voting choices are
>> now :
>> >
>> > - either definitely disabling array to string conversion,
>> > - or keep current behavior as-is.
>> >
>> > Vote ends March 6, 00:00 (UTC).
>> replace E_NOTICE with E_RECOVERABLE_ERROR??
>>
>> it's a huge BC break.....
>>
>> I vote -1 on this.
>>
>> thanks
>> >
>> > Regards
>> >
>> > Fran=C3=A7ois
>> >
>> >
>> > --
>> > PHP Internals - PHP Runtime Development Mailing List
>> > To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>>
>> --
>> Xinchen Hui
>> @Laruence
>> http://www.laruence.com/
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
> Hello,
>
> I'm explaining here the reasons of my "-1" vote.
>
> 1) You suggest (in your PR) changing the conversion
> in _convert_to_string() but not in zend_make_printable_zval(). That makes
> it completely inconsistent.
>

Forgot to mention that if you correct this important inconsistency you
won't have 32 broken tests but hundreds.

Thanks,
Patrick

--001a11336254748ae805104d9bb5--