Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84165
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.176 as permitted sender)
MIME-Version: 1.0
Date: Mon, 02 Mar 2015 12:39:28 +0000
Message-ID: <CACwt+JehH4LcPtiG+8UKUP+nek8eA=idmnwo5QPhhAL5VrUvQQ@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>, francois@php.net
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c37d4467432e05104d8212
Subject: Re: [PHP-DEV] [RFC][VOTE] Improve array to string conversion
From: patrickallaert@php.net (Patrick ALLAERT)

--001a11c37d4467432e05104d8212
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Le mer. 25 f=C3=A9vr. 2015 =C3=A0 12:16, Xinchen Hui <laruence@php.net> a =
=C3=A9crit :

Hey:
>
> On Tue, Feb 24, 2015 at 12:06 AM, Fran=C3=A7ois Laupretre <francois@php.n=
et>
> wrote:
> > Hi,
> >
> > Starting the vote for https://wiki.php.net/rfc/array-to-string.
> >
> > Please note that, while the initial RFC proposed both options of either
> > fully supporting the feature, or disabling it, the voting choices are
> now :
> >
> > - either definitely disabling array to string conversion,
> > - or keep current behavior as-is.
> >
> > Vote ends March 6, 00:00 (UTC).
> replace E_NOTICE with E_RECOVERABLE_ERROR??
>
> it's a huge BC break.....
>
> I vote -1 on this.
>
> thanks
> >
> > Regards
> >
> > Fran=C3=A7ois
> >
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
>
>
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php


Hello,

I'm explaining here the reasons of my "-1" vote.

1) You suggest (in your PR) changing the conversion in _convert_to_string()
but not in zend_make_printable_zval(). That makes it completely
inconsistent.

2) It breaks code "that works":

    if (!is_string($myArgument)) {
        $logger->log("Invalid argument passed: " $myArgument)
    }

Yes, var_export() could have been used, but it breaks something that
"worked" before and this is therefore an important BC break.

3) I am wondering what it really *brings* to devs by changing E_NOTICE to
E_RECOVERABLE_ERROR.

Those that want to know when this is happening can already with E_NOTICE in
their error_reporting.
Those that do not actually care might probably not care more.
I'm worried that those will *fix* issues like this:

    $diff =3D array_diff($multiDimensionalArray1, $multiDimensionalArray2);

with:

    $diff =3D @array_diff($multiDimensionalArray1, $multiDimensionalArray2)=
;

I'm not fundamentally against the idea to break the execution when this is
happening, but I'd rather *opt in* for it, especially if:

    $weird =3D (string) $anArray;

would generate an error because of a conversion with loss, while:

    $oops =3D (float) "one hundred";

would simply not break *and* do not provide even a notice!

I'd rather introduce an E_CONVERSION_LOSS which would be triggered in all
case of conversion loss than just targeting the specific "array -> string"
case.

Thanks,
Patrick

--001a11c37d4467432e05104d8212--