Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84111
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mabe.berlin from 80.237.132.167 cause and error)
Message-ID: <54F35C0F.4090905@mabe.berlin>
Date: Sun, 01 Mar 2015 19:35:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CA+kxMuQP76wjEAx8U1JL=VLi-mdrmEwfX_0DDqDibTHZwpqDyg@mail.gmail.com>
In-Reply-To: <CA+kxMuQP76wjEAx8U1JL=VLi-mdrmEwfX_0DDqDibTHZwpqDyg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Constructor behaviour of internal
 classes
From: dev@mabe.berlin (Marc Bennewitz)

Hi Dan,

Am 01.03.2015 um 15:55 schrieb Dan Ackroyd:
> Hi Internals,
>
> This email is to announce the formal opening of discussion for an RFC
> to clean up the behaviour of the constructors shown by several
> internal classes.
>
> https://wiki.php.net/rfc/internal_constructor_behaviour
I really like this RFC as it reduces WTF moments a lot!

One note from my perspective:
The class "PDORow" is not instantiable and triggers a fatal errors 
currently. You propose to change the fatal error into an exception. 
That's definitely better but it's an behavior not possible to 
implemented in user land code as it would be impossible to get such an 
object.

To define a class not instantiable in user land would be to define the 
constructor private/protected.

Btw. What are the reasons to not make this class instantiable / extendable ?

Thoughts?

>
> For reference this was discussed before
> https://marc.info/?l=php-internals&m=142150339323854&w=2
>
> As this RFC targets PHP 7, I plan to open the voting before the cut-off date.
>
> cheers
> Dan
>