Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:84071 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60137 invoked from network); 28 Feb 2015 08:00:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Feb 2015 08:00:43 -0000 Authentication-Results: pb1.pair.com header.from=francois@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=francois@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 212.27.42.2 as permitted sender) X-PHP-List-Original-Sender: francois@php.net X-Host-Fingerprint: 212.27.42.2 smtp2-g21.free.fr Received: from [212.27.42.2] ([212.27.42.2:10506] helo=smtp2-g21.free.fr) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 45/00-59402-9A571F45 for ; Sat, 28 Feb 2015 03:00:42 -0500 Received: from moorea (unknown [82.240.16.115]) by smtp2-g21.free.fr (Postfix) with ESMTP id 69E684B022F; Sat, 28 Feb 2015 09:00:14 +0100 (CET) Reply-To: To: "'Benjamin Eberlei'" , "'Damien Tournoud'" Cc: "'Zeev Suraski'" , "'PHP internals'" References: In-Reply-To: Date: Sat, 28 Feb 2015 09:00:33 +0100 Message-ID: <0bc401d0532c$a1129380$e337ba80$@php.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHbEgvqZ08kgCvmYfG4mXODzCFejgH/2bYmAeA2IXic0TNZQA== Content-Language: fr X-Antivirus: avast! (VPS 150227-0, 27/02/2015), Outbound message X-Antivirus-Status: Clean Subject: RE: [PHP-DEV] Coercive STH - some real world tests and updated RFC From: francois@php.net (=?utf-8?Q?Fran=C3=A7ois_Laupretre?=) > De : Benjamin Eberlei [mailto:kontakt@beberlei.de] > > The funny thing is that the fix for this is: >=20 > - substr($image, strrpos($image, "\n") + 1) > + (string)substr($image, strrpos($image, "\n") + 1) >=20 > Which is that sort of casting that is put forward as argument against = the > dual/strict mode. It is just one possible fix, but definitely not the one I would suggest, = because too permissive. No controversy please, because both are valid. I = would just prefer adding a test like 'if ($result=3D=3D=3Dfalse) = $result=3D'';'. Regards Fran=C3=A7ois