Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84069
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.220.45 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NptrtBwUiH0UrwAYa5LDiJ7fna_6At0yBw64tH6oaagPA@mail.gmail.com>
References: <CAL=_i_mdb1GvYFZr1ZEqvCgZ3+um-ZYuz5xAFZuwjwBcXsEk3Q@mail.gmail.com>
	<CAFMT4NptrtBwUiH0UrwAYa5LDiJ7fna_6At0yBw64tH6oaagPA@mail.gmail.com>
Date: Sat, 28 Feb 2015 06:38:13 +0000
Message-ID: <CAL=_i_kUeg=4qubpccpr4OLrZw4pSey3tarNKhPm6Wdu7K3Qtg@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11380cd6b349ac0510203a01
Subject: Re: [PHP-DEV] [VOTE] Expectations
From: pthreads@pthreads.org (Joe Watkins)

--001a11380cd6b349ac0510203a01
Content-Type: text/plain; charset=UTF-8

Morning Internals,

    As mentioned on the RFC, voting finished last night at midnight.

    The vote passed with a majority (50%+) in favour of custom exceptions,
however ...

    When the patch was originally written assert (expect) was a language
construct, and so the exception message wasn't constructed if the assertion
passed.

    In the current patch, assert is still a function call, so to use custom
assertions would cost considerably because the custom exception is a
parameter (so, +1 object per assertion regardless of result).

    Because of this, we are not going to merge with custom exceptions
enabled, they should not be crippling, another RFC will have to be written
to deal with custom exceptions if that's something we want moving forward.

Cheers
Joe

--001a11380cd6b349ac0510203a01--