Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84020
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 209.85.212.175 cause and error)
MIME-Version: 1.0
In-Reply-To: <54F08C76.9030600@php.net>
References: <CACouGvmRKX+qrexHfoW-9k0E9vW-ZPkRc6oz0vZ1g9CH7krQMQ@mail.gmail.com>
	<54F08C76.9030600@php.net>
Date: Fri, 27 Feb 2015 16:31:29 +0100
Message-ID: <CAEPJdukipYEn0sJ4u6H48Ey-RU0DNAVDHg+C17JFrLftGj6MTA@mail.gmail.com>
To: Sebastian Bergmann <sebastian@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c38910f8d17f0510138fa3
Subject: Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing
From: kontakt@beberlei.de (Benjamin Eberlei)

--001a11c38910f8d17f0510138fa3
Content-Type: text/plain; charset=UTF-8

On Fri, Feb 27, 2015 at 4:25 PM, Sebastian Bergmann <sebastian@php.net>
wrote:

> Am 27.02.2015 um 01:29 schrieb Matthew Weier O'Phinney:
> > - PHPUnit passes a boolean false to `debug_backtrace()`... which is
> documented
> >   as expecting an integer! (There are actually several constant values it
> >   accepts, all of which are integer values.) In this case, PHPUnit is
> relying
> >   on the fact that the engine casts booleans to the integers 0 and 1.
> (Zeev has
> >   written to the list already indicating that this coercion path will be
> >   supported in the patch.)
> > - PHPUnit is passing the results of $reflector->getDocComment() blindly
> to
> >   substr() and preg_match*(). getDocComment() is documented as returning
> EITHER
> >   a string OR boolean false. Again, PHPUnit is relying on PHP to cast
> boolean
> >   false to an empty string. (Zeev has also indicated this coercion path
> may be
> >   re-introduced.)
>
>  Pull requests for PHPUnit would be appreciated ;-)


https://gist.github.com/beberlei/8a33ae940829f1186da2 <- these are the
necessary changes for dev-msater to run on php7+coercive patch

>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a11c38910f8d17f0510138fa3--