Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:84015 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86861 invoked from network); 27 Feb 2015 15:25:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Feb 2015 15:25:45 -0000 Authentication-Results: pb1.pair.com smtp.mail=sebastian@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=sebastian@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 93.190.64.238 as permitted sender) X-PHP-List-Original-Sender: sebastian@php.net X-Host-Fingerprint: 93.190.64.238 mail-2.de-punkt.de Received: from [93.190.64.238] ([93.190.64.238:38377] helo=mail-99.de-punkt.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 67/55-32582-87C80F45 for ; Fri, 27 Feb 2015 10:25:45 -0500 Received: from localhost (localhost [127.0.0.1]) by mail-99.de-punkt.de (Postfix) with ESMTP id C48123A275 for ; Fri, 27 Feb 2015 16:25:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail-2.de-punkt.de Received: from mail-99.de-punkt.de ([127.0.0.1]) by localhost (mail-2.de-punkt.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89J44oLnxYN2 for ; Fri, 27 Feb 2015 16:25:41 +0100 (CET) Received: from [192.168.178.24] (p57BDFA1D.dip0.t-ipconnect.de [87.189.250.29]) (Authenticated sender: php@sebastian-bergmann.de) by mail-99.de-punkt.de (Postfix) with ESMTPSA id 4E8E53A1DA for ; Fri, 27 Feb 2015 16:25:41 +0100 (CET) Message-ID: <54F08C76.9030600@php.net> Date: Fri, 27 Feb 2015 16:25:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing From: sebastian@php.net (Sebastian Bergmann) Am 27.02.2015 um 01:29 schrieb Matthew Weier O'Phinney: > - PHPUnit passes a boolean false to `debug_backtrace()`... which is documented > as expecting an integer! (There are actually several constant values it > accepts, all of which are integer values.) In this case, PHPUnit is relying > on the fact that the engine casts booleans to the integers 0 and 1. (Zeev has > written to the list already indicating that this coercion path will be > supported in the patch.) > - PHPUnit is passing the results of $reflector->getDocComment() blindly to > substr() and preg_match*(). getDocComment() is documented as returning EITHER > a string OR boolean false. Again, PHPUnit is relying on PHP to cast boolean > false to an empty string. (Zeev has also indicated this coercion path may be > re-introduced.) Pull requests for PHPUnit would be appreciated ;-)