Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84002
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 209.85.212.179 cause and error)
MIME-Version: 1.0
In-Reply-To: <CALWK-fghdLMjt5yMMb23mnf0dNt+Mnx_tOYdLopfxLZFZvzTKA@mail.gmail.com>
References: <d238d736f8fcde9e649cb38c9b05fcc1@mail.gmail.com>
	<CALWK-fghdLMjt5yMMb23mnf0dNt+Mnx_tOYdLopfxLZFZvzTKA@mail.gmail.com>
Date: Fri, 27 Feb 2015 14:45:23 +0100
Message-ID: <CAEPJdumpCKfdz_gBjBnrH9WVviLp6YtDsSWJXHB+p0Nz8Cs=GA@mail.gmail.com>
To: Damien Tournoud <damz@damz.org>
Cc: Zeev Suraski <zeev@zend.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01419d1c8b662105101214b4
Subject: Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC
From: kontakt@beberlei.de (Benjamin Eberlei)

--089e01419d1c8b662105101214b4
Content-Type: text/plain; charset=UTF-8

On Fri, Feb 27, 2015 at 2:37 PM, Damien Tournoud <damz@damz.org> wrote:

> Hi Zeev,
>
> On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski <zeev@zend.com> wrote:
>
> > Drupal homepage:  One new E_DEPRECATED warning, which seems to catch a
> > real bug, or at least faulty looking code:
> >   $path = trim($path, '/');  // raises E_DEPRECATED, as $path is boolean
> > false.
> >   return $path;
> >
> > Drupal admin interface (across the all pages):  One  new E_DEPRECATED
> > warning, which again seems to catch a real bug - stripslsahes() operating
> > on a boolean.
> >
>
> All those are due to a bug in substr(), that we see now only thanks to
> proper type identification. There is no reason for substr() to ever return
> a boolean. It really needs to be fix to always return a string.
>

Yes, weird behavior that substr("", 2, 2); for example returns false. But
changing that is just another evil BC break.


>
> Damien
>

--089e01419d1c8b662105101214b4--