Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:84000
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain damz.org designates 209.85.212.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <d238d736f8fcde9e649cb38c9b05fcc1@mail.gmail.com>
References: <d238d736f8fcde9e649cb38c9b05fcc1@mail.gmail.com>
Date: Fri, 27 Feb 2015 14:37:50 +0100
Message-ID: <CALWK-fghdLMjt5yMMb23mnf0dNt+Mnx_tOYdLopfxLZFZvzTKA@mail.gmail.com>
To: Zeev Suraski <zeev@zend.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e013c625c911866051011f95f
Subject: Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC
From: damz@damz.org (Damien Tournoud)

--089e013c625c911866051011f95f
Content-Type: text/plain; charset=UTF-8

Hi Zeev,

On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski <zeev@zend.com> wrote:

> Drupal homepage:  One new E_DEPRECATED warning, which seems to catch a
> real bug, or at least faulty looking code:
>   $path = trim($path, '/');  // raises E_DEPRECATED, as $path is boolean
> false.
>   return $path;
>
> Drupal admin interface (across the all pages):  One  new E_DEPRECATED
> warning, which again seems to catch a real bug - stripslsahes() operating
> on a boolean.
>

All those are due to a bug in substr(), that we see now only thanks to
proper type identification. There is no reason for substr() to ever return
a boolean. It really needs to be fix to always return a string.

Damien

--089e013c625c911866051011f95f--