Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83989
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.223.172 as permitted sender)
References: <CACouGvmRKX+qrexHfoW-9k0E9vW-ZPkRc6oz0vZ1g9CH7krQMQ@mail.gmail.com>
In-Reply-To: <CACouGvmRKX+qrexHfoW-9k0E9vW-ZPkRc6oz0vZ1g9CH7krQMQ@mail.gmail.com>
MIME-Version: 1.0
Thread-Index: AQI+foPC9+gKUbaeko12y549Xfdpdpwn5lcg
Date: Fri, 27 Feb 2015 11:48:22 +0200
Message-ID: <e37cf5beb7508ac8a9239182f91184d3@mail.gmail.com>
To: "Matthew Weier O'Phinney" <matthew@zend.com>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: RE: [PHP-DEV] Follow-up to STH user experience, this time with actual testing
From: zeev@zend.com (Zeev Suraski)

> - PHPUnit passes a boolean false to `debug_backtrace()`... which is
> documented
>   as expecting an integer! (There are actually several constant values it
>   accepts, all of which are integer values.) In this case, PHPUnit is
> relying
>   on the fact that the engine casts booleans to the integers 0 and 1.
> (Zeev has
>   written to the list already indicating that this coercion path will be
>   supported in the patch.)

Matthew,

I just wanted to point out that actually, supporting boolean->int coercion
is not planned.  Converting boolean to integer is actually a very likely
scenario where you'd have an outcome that you didn't expect.  It's debatable
whether sending false to a bitmask is OK or not, but given it's a bitmask,
an explicit 0 is a lot more correct.

> - PHPUnit is passing the results of $reflector->getDocComment() blindly to
>   substr() and preg_match*(). getDocComment() is documented as returning
> EITHER
>   a string OR boolean false. Again, PHPUnit is relying on PHP to cast
> boolean
>   false to an empty string. (Zeev has also indicated this coercion path
> may be
>   re-introduced.)

We're looking to re-introduce string->boolean (which will likely be common
in database scenarios), but not the other way around - where it's very
likely hiding a bug.  Virtually all of the boolean->string coercions that
were flagged as deprecated by the patch were at the very least suspects of
being real world bugs.

Thanks!

Zeev