Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:8397
Return-Path: <paj@pearfr.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 62915 invoked by uid 1010); 5 Mar 2004 20:27:36 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 62881 invoked by uid 1007); 5 Mar 2004 20:27:36 -0000
To: internals@lists.php.net
Date: Fri, 5 Mar 2004 21:29:21 +0100
Message-ID: <20040305212921.68a3081a@siemenslaptop.localdomain>
References: <5.1.0.14.2.20040305221612.023173b0@127.0.0.1>
X-Newsreader: Sylpheed version 0.9.9claws (GTK+ 1.2.10; i386-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: multipart/mixed;
 boundary="Multipart=_Fri__5_Mar_2004_21_29_21_+0100_/=1mpPHt2ofFRfPA"
X-Posted-By: 80.236.18.23
Subject: Re: RC1
From: paj@pearfr.org (Pierre-Alain Joye)

--Multipart=_Fri__5_Mar_2004_21_29_21_+0100_/=1mpPHt2ofFRfPA
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 05 Mar 2004 22:18:09 +0200
andi@zend.com (Andi Gutmans) wrote:

> definitely be fixed. A couple of others don't look like show
> stoppers. If there's anyone here who can look at the non-Zend
> Engine ones that would be nice. 

Is it ok to commit this patch (attachment) to fix #27238? (Do not
know who still maintain this part)

pierre


--Multipart=_Fri__5_Mar_2004_21_29_21_+0100_/=1mpPHt2ofFRfPA
Content-Type: text/plain;
 name="bug27238.txt"
Content-Disposition: attachment;
 filename="bug27238.txt"
Content-Transfer-Encoding: 7bit

Index: iptc.c
===================================================================
RCS file: /repository/php-src/ext/standard/iptc.c,v
retrieving revision 1.45
diff -u -u -p -r1.45 iptc.c
--- iptc.c	8 Jan 2004 08:17:33 -0000	1.45
+++ iptc.c	5 Mar 2004 20:22:56 -0000
@@ -320,7 +320,7 @@ PHP_FUNCTION(iptcparse)
 	tagsfound = 0; /* number of tags already found */
 
 	while (inx < length) { /* find 1st tag */
-		if ((buffer[inx] == 0x1c) && (buffer[inx+1] == 0x02)){ 
+		if ((buffer[inx] == 0x1c) && ((buffer[inx+1] == 0x01) || (buffer[inx+1] == 0x02))){ 
 			break;
 		} else {
 			inx++;

--Multipart=_Fri__5_Mar_2004_21_29_21_+0100_/=1mpPHt2ofFRfPA--