Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83969
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <0acc01d05231$f2274780$d675d680$@php.net>
References: <CACouGvmRKX+qrexHfoW-9k0E9vW-ZPkRc6oz0vZ1g9CH7krQMQ@mail.gmail.com>
 <0acc01d05231$f2274780$d675d680$@php.net>
Date: Fri, 27 Feb 2015 15:59:09 +0800
Message-ID: <CABBJUpe9K7u4xOso4=2PX_1=aK_4JV2aod5YYadP+_y3-7PZ6w@mail.gmail.com>
To: francois@php.net
Cc: "Matthew Weier O'Phinney" <matthew@zend.com>, PHP Internals <internals@lists.php.net>, 
	Zeev Suraski <zeev@zend.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing
From: laruence@php.net (Xinchen Hui)

Hey:

On Fri, Feb 27, 2015 at 10:06 AM, Fran=C3=A7ois Laupretre <francois@php.net=
> wrote:
>> De : Matthew Weier O'Phinney [mailto:matthew@zend.com]
>>
>> - PHPUnit passes a boolean false to `debug_backtrace()`... which is
>> documented
>>   as expecting an integer! (There are actually several constant values i=
t
>>   accepts, all of which are integer values.) In this case, PHPUnit is re=
lying
>>   on the fact that the engine casts booleans to the integers 0 and 1. (Z=
eev has
>>   written to the list already indicating that this coercion path will be
>>   supported in the patch.)
>
> AFAIK, we won't support boolean to integer. IMO, considering Boolean as i=
nteger is  a bug and must not be supported.
in a internal developer's view:

  bool false =3D=3D=3D 0, bool true =3D=3D 1;

maybe this case should be supported?

considering such usage :

if (substr($str, strrpos($str, ':delimiter:')) {

}

this is not a really world usage, I just made it up, this codes is try
to find a last part of a string which is contacted with a dimileter
":delimiter":

like a:delimiter:b,   c:dilimiter:d

it works well before, because, if there is no match, it returns false
before.. (which we will think it's '0')

then the whole $str is returned..

but if we don't support bool false -> 0?

thanks
>
>> - PHPUnit is passing the results of $reflector->getDocComment() blindly =
to
>>   substr() and preg_match*(). getDocComment() is documented as returning
>> EITHER
>>   a string OR boolean false. Again, PHPUnit is relying on PHP to cast bo=
olean
>>   false to an empty string. (Zeev has also indicated this coercion path =
may be
>>   re-introduced.)
>
> The same as above for bool -> string.
>
> I hope you're wrong because I wouldn't like supporting boolean to scalar =
back again.
>
> Your test demonstrates this because you found undetected bugs. I am more =
and more sure that, what I first said as a joke, will prove true : during t=
he next years, STH will be used mostly as a debugging tool, proving opposit=
e arguments were FUD or, at least, phantasm.
>
> Regards
>
> Fran=C3=A7ois
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/