Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83953
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 212.27.42.2 as permitted sender)
Reply-To: <francois@php.net>
To: "'Matthew Weier O'Phinney'" <matthew@zend.com>,
	<internals@lists.php.net>
Cc: "Zeev Suraski" <zeev@zend.com>
References: <CACouGvmRKX+qrexHfoW-9k0E9vW-ZPkRc6oz0vZ1g9CH7krQMQ@mail.gmail.com>
In-Reply-To: <CACouGvmRKX+qrexHfoW-9k0E9vW-ZPkRc6oz0vZ1g9CH7krQMQ@mail.gmail.com>
Date: Fri, 27 Feb 2015 03:06:06 +0100
Message-ID: <0acc01d05231$f2274780$d675d680$@php.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQI+foPC9+gKUbaeko12y549XfdpdpwnY1lA
Content-Language: fr
Subject: RE: [PHP-DEV] Follow-up to STH user experience, this time with actual testing
From: francois@php.net (=?utf-8?Q?Fran=C3=A7ois_Laupretre?=)

> De : Matthew Weier O'Phinney [mailto:matthew@zend.com]
>
> - PHPUnit passes a boolean false to `debug_backtrace()`... which is
> documented
>   as expecting an integer! (There are actually several constant values =
it
>   accepts, all of which are integer values.) In this case, PHPUnit is =
relying
>   on the fact that the engine casts booleans to the integers 0 and 1. =
(Zeev has
>   written to the list already indicating that this coercion path will =
be
>   supported in the patch.)

AFAIK, we won't support boolean to integer. IMO, considering Boolean as =
integer is  a bug and must not be supported.

> - PHPUnit is passing the results of $reflector->getDocComment() =
blindly to
>   substr() and preg_match*(). getDocComment() is documented as =
returning
> EITHER
>   a string OR boolean false. Again, PHPUnit is relying on PHP to cast =
boolean
>   false to an empty string. (Zeev has also indicated this coercion =
path may be
>   re-introduced.)

The same as above for bool -> string.

I hope you're wrong because I wouldn't like supporting boolean to scalar =
back again.

Your test demonstrates this because you found undetected bugs. I am more =
and more sure that, what I first said as a joke, will prove true : =
during the next years, STH will be used mostly as a debugging tool, =
proving opposite arguments were FUD or, at least, phantasm.

Regards

Fran=C3=A7ois