Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83925
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54EB8B54.5040303@beccati.com>
References: <CADxrgCPA-Ehmgr-fn8e9UDMBJE-6pJyiXRuJB9qvQm3RdBZyUw@mail.gmail.com>
	<CAGa2bXaeT37RFCvhMKLgEymYo8J-DFSvJc0O1gV+Ahs061SU4Q@mail.gmail.com>
	<54E9B34C.80202@beccati.com>
	<CAGa2bXaMabRKa6a0dCNED8Pa7CW4vKdSXoWSBZWFq5mVwZ9H=g@mail.gmail.com>
	<54EAF61C.60005@beccati.com>
	<CADxrgCM3HYdpp-M6Z-e=RuCa+XrvWWOht_j-cMf7=+jCTxybiA@mail.gmail.com>
	<54EB8B54.5040303@beccati.com>
Date: Thu, 26 Feb 2015 15:33:37 -0500
Message-ID: <CADxrgCP1=q9_1NGff5vypV+H7jWtwOVzusDy6GC1vC7ZnzsQXQ@mail.gmail.com>
To: Matteo Beccati <php@beccati.com>
Cc: Yasuo Ohgaki <yohgaki@ohgaki.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113cef2ea74c14051003aa43
Subject: Re: [PHP-DEV] PDO_DBLIB type handling
From: adam.baratz@gmail.com (Adam Baratz)

--001a113cef2ea74c14051003aa43
Content-Type: text/plain; charset=UTF-8

Thanks, I posted a pull request against v5.6.6:
https://github.com/php/php-src/pull/1122

If this goes through, I can do a separate patch against master. (This ext
has changed very little over time so it would be largely the same.)

On Mon, Feb 23, 2015 at 3:19 PM, Matteo Beccati <php@beccati.com> wrote:

> On 23/02/2015 21:12, Adam Baratz wrote:
>
>> Makes sense to me. (I'm new at how this community works.) Should I include
>> a patch with the feature request ticket? Should I be working against
>> master?
>>
>
> I'd say you should start by submitting a bug report (if there isn't one
> already). Then a pull request on github would probably be easier for
> everyone.
>
> Even though the old behaviour should be possible by setting
> PDO::ATTR_STRINGIFY_FETCHES to true, it is is a fairly big behaviour change
> for PDO_DBLIB, so master-only would be your best bet.
>
> My .02$
>
>
>
> Cheers
> --
> Matteo Beccati
>
> Development & Consulting - http://www.beccati.com/
>

--001a113cef2ea74c14051003aa43--