Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83885
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEPJdunZpePBb1w6=AEZKxjj_7EZaPLGONkBr40q5=9fOXptpw@mail.gmail.com>
References: <CA+9eiLsDt9K+DNrnT3Dh7eMwOBCoaP_xgnjNtptu03P8JnmzwQ@mail.gmail.com>
	<CAEPJdunZpePBb1w6=AEZKxjj_7EZaPLGONkBr40q5=9fOXptpw@mail.gmail.com>
Date: Thu, 26 Feb 2015 14:56:35 +0400
Message-ID: <CA+9eiLuweW=_V8EgqJ40Rr-gXmVQLBnF4FB57AC9f_Z57A9Lww@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: Anthony Ferrara <ircmaxell@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0115f0480c665f050ffb9bd1
Subject: Re: [PHP-DEV] Strict typing and callback vs declare()
From: dmitry@zend.com (Dmitry Stogov)

--089e0115f0480c665f050ffb9bd1
Content-Type: text/plain; charset=UTF-8

On Thu, Feb 26, 2015 at 1:34 PM, Benjamin Eberlei <kontakt@beberlei.de>
wrote:

>
>
> On Thu, Feb 26, 2015 at 11:10 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Anthony,
>>
>> What do you think about using a user level callback for strict type checks
>> instead of declare(). It won't allow changing behavior per file, but this
>> has its own cons and pros.
>>
>> <?php
>> set_strict_type_checker(function ($class_name, $function_nume, $arg_num,
>> $expected_type, $value, $file, $line) {
>>   ...
>>   return false;
>> });
>> include("orig_index.php");
>> ?>
>>
>> If callback is not set, arguments are converted according to standard
>> rules, if set and returns false - fatal error or exception is thrown.
>>
>> The implementation should be simpler and more efficient than using
>> declare().
>>
>> Thanks. Dmitry.
>>
>
> This ruins portability with third party libraries completely.
>

Not completely, because checker may be smart enough to return "true" for
third party files.

<?php
set_strict_type_checker(function ($class_name, $function_nume,
$arg_num,$expected_type, $value, $file, $line) {
   if (!my_own_file($filename)) {
     return true;
   }
   ...
   return false;
});
include("index.php");
?>

And you won't have to modify each file in your project adding
declare(strict_types=1).

Thanks. Dmitry.

--089e0115f0480c665f050ffb9bd1--