Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83884
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.192.172 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAEPJdunZpePBb1w6=AEZKxjj_7EZaPLGONkBr40q5=9fOXptpw@mail.gmail.com>
References: <CA+9eiLsDt9K+DNrnT3Dh7eMwOBCoaP_xgnjNtptu03P8JnmzwQ@mail.gmail.com>
	<CAEPJdunZpePBb1w6=AEZKxjj_7EZaPLGONkBr40q5=9fOXptpw@mail.gmail.com>
Date: Thu, 26 Feb 2015 10:43:47 +0000
Message-ID: <CAL=_i_mMHBFsc+JOQt_cajdRXvOQKzRJjLdsPS85VfgaKhfOHw@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: Dmitry Stogov <dmitry@zend.com>, Anthony Ferrara <ircmaxell@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b5d87193ea0c6050ffb6dd1
Subject: Re: [PHP-DEV] Strict typing and callback vs declare()
From: pthreads@pthreads.org (Joe Watkins)

--047d7b5d87193ea0c6050ffb6dd1
Content-Type: text/plain; charset=UTF-8

> The implementation should be simpler and more efficient than using
declare().

This can't really be correct, if a call to

function mine(int $one, double $two) {

}

results in three function calls then that's going to cost considerably.

I don't like the idea of user function being called, but don't hate the
idea of an internal
API that allows an extension to implement a type system.

It could be much simpler, like turning zend_verify_arg_type into a pointer
to a function like
we did with gc function.

All of this is inferior to dual mode, in my opinion.

Cheers
Joe

On Thu, Feb 26, 2015 at 10:34 AM, Benjamin Eberlei <kontakt@beberlei.de>
wrote:

> On Thu, Feb 26, 2015 at 11:10 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
> > Hi Anthony,
> >
> > What do you think about using a user level callback for strict type
> checks
> > instead of declare(). It won't allow changing behavior per file, but this
> > has its own cons and pros.
> >
> > <?php
> > set_strict_type_checker(function ($class_name, $function_nume, $arg_num,
> > $expected_type, $value, $file, $line) {
> >   ...
> >   return false;
> > });
> > include("orig_index.php");
> > ?>
> >
> > If callback is not set, arguments are converted according to standard
> > rules, if set and returns false - fatal error or exception is thrown.
> >
> > The implementation should be simpler and more efficient than using
> > declare().
> >
> > Thanks. Dmitry.
> >
>
> This ruins portability with third party libraries completely.
>

--047d7b5d87193ea0c6050ffb6dd1--