Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83870
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain gielfeldt.dk from 209.85.217.179 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAEPJdu=L2Rx68epUw7NxqrKGcn5Y8Tx+awMLuR8NXG4rct76YA@mail.gmail.com>
References: <CAGnBX03-qsCySW0qOZFWk60p1MaJe-ed1DN+z2fjAqJJLqu8fg@mail.gmail.com>
 <CAEPJdu=L2Rx68epUw7NxqrKGcn5Y8Tx+awMLuR8NXG4rct76YA@mail.gmail.com>
Date: Thu, 26 Feb 2015 07:36:09 +0100
Message-ID: <CAGnBX02qRbKULtaQoqcjbFdzX8B2HuQoVSMMM2Eb6rPhrEzktg@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0116048ee0b36f050ff7f8d4
Subject: Re: [PHP-DEV] Feature request and RFC
From: thomas@gielfeldt.dk (Thomas Gielfeldt)

--089e0116048ee0b36f050ff7f8d4
Content-Type: text/plain; charset=UTF-8

2015-02-24 17:36 GMT+01:00 Benjamin Eberlei <kontakt@beberlei.de>:

> Hi,
>
> On Tue, Feb 24, 2015 at 5:17 PM, Thomas Gielfeldt <thomas@gielfeldt.dk>
> wrote:
>
>> Hi internals.
>>
>> I've made PR proposing a feature request: A new interface Sortable.
>>
>> https://github.com/php/php-src/pull/1116
>>
>> If possible, I would like to create and RFC describing this in more
>> detail,
>> and perhaps get a voting on.
>>
>
> so you need to implement all methods? This can probably be considered a
> violation of the Interface Segregation Principle. But adding an interface
> for each method seems a bit much as well.
>
>>
>>
Another solution could be:

/** @ingroup SPL
 * @brief This Interface allows to hook into the global Xsort() functions.
 * @since PHP 5.6
 */
interface Sortable
{
  /**
   * Sort the entries by values.
   *
   * @param integer $sort_flags
   *   SORT_REGULAR:       compare items normally (don't change types)
   *   SORT_NUMERIC:       compare items numerically
   *   SORT_STRING:        compare items as strings
   *   SORT_LOCALE_STRING: compare items as strings, based on the current
locale. It uses the locale, which can be changed using setlocale()
   *   SORT_NATURAL:       compare items as strings using "natural
ordering" like natsort()
   *   SORT_FLAG_CASE:     can be combined (bitwise OR) with SORT_STRING or
SORT_NATURAL to sort strings case-insensitively
   *   SORT_FLAG_REVERSE:  can be combined (bitwise OR) with any of the
other options to sort in reverse
   */
  function sort($sort_flags = SORT_REGULAR);

  /** Sort the entries by values using user defined function.
   */
  function usort(mixed cmp_function);
}


/** @ingroup SPL
 * @brief This Interface allows to hook into the global XaXsort() functions.
 * @since PHP 5.6
 */
interface SortableAssoc
{
  /**
   * Sort the entries by values and maintain indexes.
   *
   * @param integer $sort_flags
   *   SORT_REGULAR:       compare items normally (don't change types)
   *   SORT_NUMERIC:       compare items numerically
   *   SORT_STRING:        compare items as strings
   *   SORT_LOCALE_STRING: compare items as strings, based on the current
locale. It uses the locale, which can be changed using setlocale()
   *   SORT_NATURAL:       compare items as strings using "natural
ordering" like natsort()
   *   SORT_FLAG_CASE:     can be combined (bitwise OR) with SORT_STRING or
SORT_NATURAL to sort strings case-insensitively
   *   SORT_FLAG_REVERSE:  can be combined (bitwise OR) with any of the
other options to sort in reverse
   */
  function asort($sort_flags = SORT_REGULAR);

  /** Sort the entries by values using user defined function and maintain
index.
   */
  function uasort(mixed cmp_function);
}

/** @ingroup SPL
 * @brief This Interface allows to hook into the global XkXsort() functions.
 * @since PHP 5.6
 */
interface SortableKeys
{
  /**
   * Sort the entries by key.
   *
   * @param integer $sort_flags
   *   SORT_REGULAR:       compare items normally (don't change types)
   *   SORT_NUMERIC:       compare items numerically
   *   SORT_STRING:        compare items as strings
   *   SORT_LOCALE_STRING: compare items as strings, based on the current
locale. It uses the locale, which can be changed using setlocale()
   *   SORT_NATURAL:       compare items as strings using "natural
ordering" like natsort()
   *   SORT_FLAG_CASE:     can be combined (bitwise OR) with SORT_STRING or
SORT_NATURAL to sort strings case-insensitively
   *   SORT_FLAG_REVERSE:  can be combined (bitwise OR) with any of the
other options to sort in reverse
   */
  function ksort($sort_flags = SORT_REGULAR);

  /** Sort the entries by key using user defined function.
   */
  function uksort(mixed cmp_function);
}


I have a working implementation of this also.


> Thanks
>>
>> Br,
>>
>> Thomas Gielfeldt
>>
>
>

--089e0116048ee0b36f050ff7f8d4--