Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83799
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAyV7nFFC8pp6zRP-qMOFD5RiKaHkAsHgmQ1=Uj9WD5hWUvurA@mail.gmail.com>
References: <CAAyV7nGjdguX=4Nt0H=kYnwg8rZ1BkWf8duGZfzheOXXV61pqA@mail.gmail.com>
	<CAAyV7nE+JJPr4iRiFfJg74UVZ_c6HieOmpPQWe6zwnY==m7Zhw@mail.gmail.com>
	<CAAyV7nGOh7FgkbkPGwALmU4SDOs=LvkijAPJeNcG3qrMo7-z-Q@mail.gmail.com>
	<CAAyV7nFfzaw=M0En4_3Lt5MYQ7H+ePCzFOuM4wndehxJER7NXQ@mail.gmail.com>
	<CA+9eiLuuH7v4Vvf8iDzvh=vho9mdPUpvSVHwuP6+JdNVkqLS9A@mail.gmail.com>
	<CA+9eiLup3jEPcQaNbEQXQ8js0t9-thVRG8fCXHScL3K=aU20Ow@mail.gmail.com>
	<op.xul2slya7q1gix@nikita-hp-elitebook-750-g1>
	<CA+9eiLsuK7G-Wz3PfV5=aEQeUQk4RDYARNd7JSFWAynyY4o0-A@mail.gmail.com>
	<op.xul4bazz7q1gix@nikita-hp-elitebook-750-g1>
	<CA+9eiLv-UMBtFYvD0Aps4SpuUoEGBiwWjQH8tVz0OYiW73TKmA@mail.gmail.com>
	<CAAyV7nFFC8pp6zRP-qMOFD5RiKaHkAsHgmQ1=Uj9WD5hWUvurA@mail.gmail.com>
Date: Wed, 25 Feb 2015 19:29:26 +0400
Message-ID: <CA+9eiLv_qjfvZ2Q2GaEU4Hcu1c8EJ3qb6SBib5he7-vOnQ4hhQ@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: Niktia Nefedov <inefedor@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf3071c7c0fc2b91050feb4ca1
Subject: Re: [PHP-DEV] Re: [RFC-Discuss] Scalar Type Declarations v0.5
From: dmitry@zend.com (Dmitry Stogov)

--20cf3071c7c0fc2b91050feb4ca1
Content-Type: text/plain; charset=UTF-8

On Wed, Feb 25, 2015 at 6:09 PM, Anthony Ferrara <ircmaxell@gmail.com>
wrote:

> Dmitry,
>
> > The object on the call-site should remain to be an object (if it's not
> > passed by reference), however the called function will receive a string.
> > It works in PHP-5 and PHP-7. Nothing should be changed.
> >
> > $ sapi/cli/php -r 'class X {function __toString(){return "abc";}} $x=new
> X;
> > var_dump(strlen($x)); var_dump($x);'
> > int(3)
> > object(X)#1 (0) {
> > }
> >
> > However, declare(strict_types=1) will break this. see
> >
> https://github.com/ircmaxell/php-src/compare/scalar_type_hints_v5#diff-ef5bf53d1412b50f85d125ca4fe84741R1182
>
> "Break" is a loaded term.
>

OK. it's a BC break.
What is the reason for __toString() if it's not going to be called.


>
> It's intentionally not calling __toString, because that's not only a
> cast (like "5" -> int(5)), but it's a lossy cast (like 5.5 -> int(5)
> or "5 apples" => int(5)).
>

this is about conversion rules that may be safe or not.


> One point of strict mode is that it's there intentionally to turn off
> magic. It's there to make things explicit, predictable and robust.
>

turn off magic to get what? Need to write explicit (int) or (string)?
We have a number of such patterns that hide errors even in PHP sources (in
C).

Thanks. Dmitry.


> And it's fully opt-in, so there's nothing to "break". It's entirely
> new behavior.

Anthony
>

--20cf3071c7c0fc2b91050feb4ca1--