Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:83774 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 22688 invoked from network); 25 Feb 2015 12:28:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Feb 2015 12:28:05 -0000 Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.179 as permitted sender) X-PHP-List-Original-Sender: xinchen.h@zend.com X-Host-Fingerprint: 209.85.217.179 mail-lb0-f179.google.com Received: from [209.85.217.179] ([209.85.217.179:35681] helo=mail-lb0-f179.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DB/4C-62407-1DFBDE45 for ; Wed, 25 Feb 2015 07:28:02 -0500 Received: by lbjb6 with SMTP id b6so3491591lbj.2 for ; Wed, 25 Feb 2015 04:27:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=6ucjd1ytCdM2CqKmIkPxpDZDY5/JgLBOsvvocHjdLvU=; b=evwO0f/GC9f4q2xVNlXYuHsCB3MVObRA0mvknZeEciYq4IaKveZPLrra2kOUZV/hwC SkNm/yXJ0I7WVrJBBCAtDXMJFGqCJpkqx20R0q0ionUmDq/az++awWuQlxGMLr9MEatL NVIvs0o+EMezdFp2SwNrUTN9qXE49R7+El2Fw0SEfXGDUL1pcoiiv+kubGwtrwtxGxR9 hrz2Hv9AEuJe8zXnmPbyKcw+gPf0v/g/LGF6AEjSfXZQuolMu7rp1hazufBDdtE3s7FN hOxN+eXNfFQIQ+11INaYTYH+dUSpGwctwxuIsGNHTtprToYRBoruCrcyODX9RNhWpKei Pa7g== X-Gm-Message-State: ALoCoQl6qGLHCebZC1qK5uQP2r4SkwO8evpgW+yWOzqr5tkYcbky8pFGhP8zBiuAMX5LC6Vw2bYZ+oq077W6OyXbQ7Xos0WcljskFJ32VeXXT8v1iAWhRPNite+CORBVlumQPuuRQqFhLawwY/X5C9VtVJPHdrYZDA== X-Received: by 10.152.5.41 with SMTP id p9mr2614318lap.7.1424867278185; Wed, 25 Feb 2015 04:27:58 -0800 (PST) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPSA id pf1sm4003069lbc.32.2015.02.25.04.27.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Feb 2015 04:27:57 -0800 (PST) Received: by labhs14 with SMTP id hs14so3492954lab.4 for ; Wed, 25 Feb 2015 04:27:56 -0800 (PST) X-Received: by 10.152.26.199 with SMTP id n7mr2495360lag.29.1424867276096; Wed, 25 Feb 2015 04:27:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.28.198 with HTTP; Wed, 25 Feb 2015 04:27:35 -0800 (PST) In-Reply-To: <54EB7110.20407@mabe.berlin> References: <54EB7110.20407@mabe.berlin> Date: Wed, 25 Feb 2015 20:27:35 +0800 Message-ID: To: Marc Bennewitz Cc: PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Re: [RFC] Exceptions in the engine From: laruence@php.net (Xinchen Hui) Hey: On Tue, Feb 24, 2015 at 2:27 AM, Marc Bennewitz wrote: > Hi Dimitry, > > Am 19.02.2015 um 16:13 schrieb Dmitry Stogov: >> >> Hi Nikita, >> >> I refactored your implementation: https://github.com/php/php-src/pull/1095 >> >> I introduced a class hierarchy to minimize effect on existing code. >> cacth (Exception $e) won't catch new types of exceptions. >> >> BaseException (abstarct) >> +- EngineException >> +- ParaseException >> +- Exception >> +-ErrorException >> +- all other exceptions > > I really like this RFC and Exception hierarchy but one very small note: > The name of BaseException is a bit to misunderstanding to me as it clashes > with the old base exception named Exception, which is by the way very often > used as alias (use Exception as BaseExcepton). > I know this isn't a technical issue but it reduces readability a code. > > What are your thoughts about the following names ?: > > RootException > AbstractExcepton +1 for AbstarctException. thanks > >> > > > Marc > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/