Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83765
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGnBX00VHRzSWP+7skSQQhSAec-nmTz6-1Gx_azR+PODPioKRw@mail.gmail.com>
References: <CAGnBX03-qsCySW0qOZFWk60p1MaJe-ed1DN+z2fjAqJJLqu8fg@mail.gmail.com>
	<CAEPJdu=L2Rx68epUw7NxqrKGcn5Y8Tx+awMLuR8NXG4rct76YA@mail.gmail.com>
	<CAGnBX01XO+OnTJmt3U+K6m1tN-qrRnJJ-r6TOYBXHvxaw8Q0RQ@mail.gmail.com>
	<CAEbg-4Y4BSK-UN7Z182gnGZh7PQ3sUGfns0oDny8tR31gA8Jvw@mail.gmail.com>
	<CAGnBX00VHRzSWP+7skSQQhSAec-nmTz6-1Gx_azR+PODPioKRw@mail.gmail.com>
Date: Wed, 25 Feb 2015 14:15:30 +0300
Message-ID: <CAEbg-4Y=eJV=zq+6pW1ETJQWmwFxFibRZ5jPRg0jkS1nMEL5gg@mail.gmail.com>
To: Thomas Gielfeldt <thomas@gielfeldt.dk>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b86ea96cf4118050fe7c01c
Subject: Re: [PHP-DEV] Feature request and RFC
From: lisachenko.it@gmail.com (Alexander Lisachenko)

--047d7b86ea96cf4118050fe7c01c
Content-Type: text/plain; charset=UTF-8

2015-02-25 13:37 GMT+03:00 Thomas Gielfeldt <thomas@gielfeldt.dk>:

> Yeah, but the "problem" with this, is that your class' sort method, you
> have to implement all the possible permutations the flags can produce. This
> basically just squeezes the 11 functions into 1. The 1 interface with
> sort() and usort() splits this into 2 functions (8+3). With that in mind,
> I'm more inclined to choose the 4 interface approach.



For that case, move all configurations to the several classes and configure
these flags in the concrete constructors. Interface will be more simple:

interface Sortable {
    const ASC = 1;
    const DESC = 2;

    public function sort($direction = self::ASC, callable $callback = null);
}

class KeySorter implements Sortable {}

--047d7b86ea96cf4118050fe7c01c--