Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83659
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXachcJAAJcK6LqsxQSAFr12Khu8V8xkMZB+_f2Ny30yPw@mail.gmail.com>
References: <CAF+90c8nqCBGWpsqdfy+EKekOm3Cw5_zzE_nKeyLK5pzROTueg@mail.gmail.com>
	<54EC5AD9.3040505@birkholz.biz>
	<CAGa2bXachcJAAJcK6LqsxQSAFr12Khu8V8xkMZB+_f2Ny30yPw@mail.gmail.com>
Date: Tue, 24 Feb 2015 13:40:21 +0100
Message-ID: <CAEp07h8PTNwv=iXeQJQ7nPK=Q2M1gmpnPx-quQyP1Eoy=SW4Aw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Dennis Birkholz <dennis@birkholz.biz>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113ba080750ab3050fd4d2d8
Subject: Re: [PHP-DEV] [VOTE] Exceptions in the engine
From: martin.keckeis1@gmail.com (Martin Keckeis)

--001a113ba080750ab3050fd4d2d8
Content-Type: text/plain; charset=UTF-8

2015-02-24 13:29 GMT+01:00 Yasuo Ohgaki <yohgaki@ohgaki.net>:

> Hi all,
>
> On Tue, Feb 24, 2015 at 8:04 PM, Dennis Birkholz <dennis@birkholz.biz>
> wrote:
>
> > Am 23.02.2015 um 19:15 schrieb Nikita Popov:
> > > A second vote will decide whether to use a BaseException based
> > inheritance
> > > hierarchy. This vote uses a simple majority.
> >
> > I like this RFC and hope it passes. I am a little concerned about
> > littering the global namespace. It would be preferable to have a single
> > namespace that is reserved for all build in classes (like \PHP) that
> > contains all classes like exceptions. The name BaseException seems to be
> > a very common one:
> > https://github.com/search?l=php&q=baseexception&type=Code finds about
> > 14k matches, so this may be a huge BC break if the actual class name is
> > not changed.
> >
>
> It seems AbstractException is better choice for BC.
>
>
> https://github.com/search?l=php&q=abstractexception&ref=searchresults&type=Code
>
> There are 661 matches, but most of them are using namespace unlike
> BaseException.
>
>
> Someone proposed to use namespace for all PHP functions/classes and
> clean global namespace up. This gives us flexibility also. e.g Providing
> compatibility to older functions/classes to mitigate BC impact.
>
> Use of namespace is BC by itself, but it may be better to consider
> namespace
> use for internal features. We don't have much time, so it may be for
> PHP8...
>
>
All "none" namespaced classnames are IMO reserved for PHP....
So if you develop an application/classes you (should) always prefix a
vendor/project namesapce.

But +1 for PHP8+ for a PHP namespace. For PHP7 please do not do too much at
once.

--001a113ba080750ab3050fd4d2d8--