Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83628
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.169 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <081001d04fe8$dcbc0160$96340420$@php.net>
References: <081001d04fe8$dcbc0160$96340420$@php.net>
Date: Tue, 24 Feb 2015 13:32:25 +0900
Message-ID: <CAGa2bXaAFEipqOP1=axNxawhYLkj=Bb2fCKEpXL0K-cefEesRg@mail.gmail.com>
To: francois <francois@php.net>
Cc: Pierre Joye <pierre.php@gmail.com>, Zeev Suraski <zeev@zend.com>, 
	Anthony Ferrara <ircmaxell@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11353862d7e7d3050fce03e3
Subject: Re: [PHP-DEV] Coercive Scalar Type Hints RFC - BC breaks
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11353862d7e7d3050fce03e3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Francois,

On Tue, Feb 24, 2015 at 1:17 PM, Fran=C3=A7ois Laupretre <francois@php.net>
wrote:

> I ran the PHP core 'make test' on a basic configuration, still running a
> significant number of 8785 tests.
>
> Note: the restrictions on numeric string conversions (leading
> chars/zeroes, trailing chars) are not simulated yet, but they shouldn't
> change the results very much.
>
> The ruleset corresponding to the coercive RFC, as it is published today,
> globally broke 7.3% of tests. From these 7.3%, 5.3% correspond to the
> disabled conversions from null to scalar types, which will probably have =
to
> be reintroduced, as it was suspected. So, if we consider that these
> conversions are re-enabled, the resulting coercive ruleset breaks 1.9% of
> the tests, which is rather positive, IMO, because there is still room for
> improvements.
>
> More details soon.
>

I'm guessing most failures are due to E_DEPRECATED.
I suggest to test without E_DEPRECATED, then it would
be fair figure for the patch. Could you run test without
E_DEPRECATED? We can use -c option for almost all
tests, I think.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11353862d7e7d3050fce03e3--