Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83598
Return-Path: <dev@mabe.berlin>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 15485 invoked from network); 23 Feb 2015 18:27:34 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 23 Feb 2015 18:27:34 -0000
Authentication-Results: pb1.pair.com header.from=dev@mabe.berlin; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=dev@mabe.berlin; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain mabe.berlin from 80.237.132.167 cause and error)
X-PHP-List-Original-Sender: dev@mabe.berlin
X-Host-Fingerprint: 80.237.132.167 wp160.webpack.hosteurope.de  
Received: from [80.237.132.167] ([80.237.132.167:36116] helo=wp160.webpack.hosteurope.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id FB/7A-01128-3117BE45 for <internals@lists.php.net>; Mon, 23 Feb 2015 13:27:32 -0500
Received: from dslb-094-222-182-032.094.222.pools.vodafone-ip.de ([94.222.182.32] helo=[192.168.178.30]); authenticated
	by wp160.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	id 1YPxj6-0001am-Qt; Mon, 23 Feb 2015 19:27:28 +0100
Message-ID: <54EB7110.20407@mabe.berlin>
Date: Mon, 23 Feb 2015 19:27:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAF+90c-7w1fLqmffYvPRhmtt8rzESEpSmW8vfMD-YfLt1mG_8w@mail.gmail.com>	<CAF+90c8NAROuCDgRajF4AN2oTc4fzmxTjtVC_OAQH=ZFm5N9Uw@mail.gmail.com> <CA+9eiLtgZq4HrXTaY_=traLAi7qR76F=HNAx=QCw7woNQOZvYg@mail.gmail.com>
In-Reply-To: <CA+9eiLtgZq4HrXTaY_=traLAi7qR76F=HNAx=QCw7woNQOZvYg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-bounce-key: webpack.hosteurope.de;dev@mabe.berlin;1424716052;895a4a9e;
Subject: Re: [PHP-DEV] Re: [RFC] Exceptions in the engine
From: dev@mabe.berlin (Marc Bennewitz)

Hi Dimitry,

Am 19.02.2015 um 16:13 schrieb Dmitry Stogov:
> Hi Nikita,
>
> I refactored your implementation: https://github.com/php/php-src/pull/1095
>
> I introduced a class hierarchy to minimize effect on existing code.
> cacth (Exception $e) won't catch new types of exceptions.
>
> BaseException (abstarct)
>   +- EngineException
>   +- ParaseException
>   +- Exception
>       +-ErrorException
>       +- all other exceptions
I really like this RFC and Exception hierarchy but one very small note:
The name of BaseException is a bit to misunderstanding to me as it 
clashes with the old base exception named Exception, which is by the way 
very often used as alias (use Exception as BaseExcepton).
I know this isn't a technical issue but it reduces readability a code.

What are your thoughts about the following names ?:

RootException
AbstractExcepton

> <snip> 

Marc