Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83590
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.179 as permitted sender)
References: <7ef509ef10bb345c792f9d259c7a3fbb@mail.gmail.com>
	<CAEPJduk3VgWYgpuJ4G0JvUXYaMoO7430Q0k7v5ifwWF_dzh9rA@mail.gmail.com>
	<9aec85c81b49009c6238ff6d8be27cd4@mail.gmail.com> <CAEPJdukoBG3M1q3UqJ9LW-GBqhVB7-ybkdJqiGENN2w10XqEhw@mail.gmail.com>
In-Reply-To: <CAEPJdukoBG3M1q3UqJ9LW-GBqhVB7-ybkdJqiGENN2w10XqEhw@mail.gmail.com>
MIME-Version: 1.0
Thread-Index: AQKcPg+jpyYspJS11b5G1A7RBHpKTgIs5D7XAe7Kvi4CGebHCJs06+dA
Date: Mon, 23 Feb 2015 19:08:31 +0200
Message-ID: <f881d1e1bb6026b96498cfd787d3fd0a@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PHP-DEV] Coercive Scalar Type Hints RFC
From: zeev@zend.com (Zeev Suraski)

> -----Original Message-----
> From: Benjamin Eberlei [mailto:kontakt@beberlei.de]
> Sent: Monday, February 23, 2015 6:54 PM
> To: Zeev Suraski
> Cc: PHP internals
> Subject: Re: [PHP-DEV] Coercive Scalar Type Hints RFC
>
> Zeev,
>
> On Sat, Feb 21, 2015 at 11:25 PM, Zeev Suraski <zeev@zend.com> wrote:
>
>
> 	Additional options we could entertain are:
>
> 	5. Go for just E_DEPRECATED in 7.0.  Change E_DEPRECATED to
> E_RECOVERABLE_ERROR in 7.1/7.2/8.0 (TBD).
>
> 	6. Same as #5, but also provide a mechanism similar to declare() as
> the temporary measure for strict campers to explicitly ask for
> E_RECOVERABLE_ERROR=E2=80=99s to be triggered.  They will no longer be ne=
cessary
> when we change E_DEPRECATED to E_RECOVERABLE_ERROR in 7.1/7.2/8.0.
>
>
> 5. BC Break too big leading to a Python2/3 situation, low adoption of
> PHP7,
> something that especially you couldn't want given that the perf
> improvements are what keeps PHP on level with HHVM. This automatically
> applies to all internal functions regardless if userland uses typehints o=
r
> not,
> wordpress will not work with this anymore, no performance comparisons
> anymore.

I don't see how that would affect PHP 7 adoption at all actually.  You can
just disable E_DEPRECATED and your upgrade would be clean.  Technically it
would have to wait to PHP 8 before we change it to E_RECOVERABLE_ERROR, giv=
e
users several years to migrate.  Given we're talking about coercive rules
and not strict rules, I actually don't expect that many failures (initial
tests of Francois' patch  results in 8% failures in our unit tests, and
that's before tweaking the rules in any way (and apparently, at least some
of them have to do with bugs in internal functions that can be easily
fixed).  It doesn't strike me as a worse migration than we did getting rid
of magic_quotes or safe_mode.  It can be done.

I'm personally now leaning towards this option as the most viable one.

> 6. Ok, so this is now getting very similar like v5 of the STH, but still
> with much
> more BC breaks.

Not at all.  With the Dual Mode RFC, we're going to have declare() and two
distinct modes even in 10 and 20 years from now, for all eternity.  It's a
new feature that's here to say.  With this, these declare()'s are a
migration feature, that will be gone in several years.  The endgame is
completely different.

Zeev