Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83543
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.176 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAF+90c-YX6tN63JwwWzn-WH2og2uffjR2YrL_JXsYKSjrQFS1Q@mail.gmail.com>
References: <CAF+90c-YX6tN63JwwWzn-WH2og2uffjR2YrL_JXsYKSjrQFS1Q@mail.gmail.com>
Date: Mon, 23 Feb 2015 14:32:15 +0900
Message-ID: <CAGa2bXYY5Yf6Aa0KxB8nxY+zJbvUTRpcJgja2Ezv4z4q5t-=xA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1133dde2f52431050fbabb52
Subject: Re: [PHP-DEV] Reclassify E_STRICT notices
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a1133dde2f52431050fbabb52
Content-Type: text/plain; charset=UTF-8

Hi Nikita,

On Mon, Feb 23, 2015 at 7:30 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> I would like to propose reclassifying our few existing E_STRICT notices and
> removing this error category:
>
>     https://wiki.php.net/rfc/reclassify_e_strict
>
> As we don't really have good guidelines on when which type of error should
> be thrown, I'm mainly going by what category other similar errors use. I'm
> open to suggestions, but hope this will not deteriorate into total
> bikeshed.
>

+1 overall.

Regarding "Only variables should be assigned by reference"

Most of errors are appropriate, but some of them may be removed.
For example, literals do not make sense so current behavior is good.

$ php -r 'array_pop([1,2,3]);'
PHP Fatal error:  Only variables can be passed by reference in Command line
code on line 1

However, emitting "Only variables should be assigned by reference" for this

$top = array_pop(some_func_returns_array()); // Code needs only top element

seems too strict, for example. I would rather PHP behaves like HHVM

 - http://3v4l.org/5AIrb.
 - http://3v4l.org/O0SXE

Is it possible relax the error for tmp variables?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a1133dde2f52431050fbabb52--