Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83477
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLtgZq4HrXTaY_=traLAi7qR76F=HNAx=QCw7woNQOZvYg@mail.gmail.com>
References: <CAF+90c-7w1fLqmffYvPRhmtt8rzESEpSmW8vfMD-YfLt1mG_8w@mail.gmail.com>
	<CAF+90c8NAROuCDgRajF4AN2oTc4fzmxTjtVC_OAQH=ZFm5N9Uw@mail.gmail.com>
	<CA+9eiLtgZq4HrXTaY_=traLAi7qR76F=HNAx=QCw7woNQOZvYg@mail.gmail.com>
Date: Sun, 22 Feb 2015 19:25:16 +0100
Message-ID: <CAF+90c_mdD0EmyJ9Z_w4yVNtoASb2OptznpNLysG7J-Ygwh_GQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b66f6db4adbe9050fb168fc
Subject: Re: [PHP-DEV] Re: [RFC] Exceptions in the engine
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7b66f6db4adbe9050fb168fc
Content-Type: text/plain; charset=UTF-8

On Thu, Feb 19, 2015 at 4:13 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Nikita,
>
> I refactored your implementation: https://github.com/php/php-src/pull/1095
>
> I introduced a class hierarchy to minimize effect on existing code.
> cacth (Exception $e) won't catch new types of exceptions.
>
> BaseException (abstarct)
>  +- EngineException
>  +- ParaseException
>  +- Exception
>      +-ErrorException
>      +- all other exceptions
>
> In case of uncaught Parse and EngineEexception PHP writes the compatible
> error message.
> I made it mainly to keep thousand PHPT tests unchanged.
> If you like we may introduce an ini option that will lead to emitting of
> "Uncaught Exception ... " with backtrace instead.
>
> The internal API was changed a bit. e.g. EngineException are thrown from
> zend_error(), if the error_code has E_EXCEPTION bit set.
> So to change some error into exception now we should change
> zend_error(E_ERROR,...) into zend_error(E_EXCEPTION|E_ERROR. ...)
>
> All tests are passed.
> I'm not sure about sapi/cli/tests/bug43177.phpt, because it started to
> fail also in master.
>
> We may need to replace E_RECOVERABLE_ERROR with E_ERROR and fix
> corresponding tests.
> Despite of this, I think the patch is good enough to be merged into master.
>
> We may decide to convert more fatal errors later, but it shouldn't prevent
> from putting RFC into vote.
>
> Thoughts?
>

I've updated some minor points in the RFC to be consistent with the new
patch. The BaseException based hierarchy will be a separate vote [1]. If
there are no further concerns I'd start voting on this RFC tomorrow.

One point wrt the patch: Do you think it would be hard to use a clean
shutdown on uncaught exceptions? This would make sure we don't forget to
free anything when throwing exceptions.

Nikita

[1]: https://wiki.php.net/rfc/engine_exceptions_for_php7#hierarchy

--047d7b66f6db4adbe9050fb168fc--