Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83409
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZYipV0u2yOireZyrqoZY_z57cPtX_t-F6vaD3--e5U2Q@mail.gmail.com>
References: <CAL=_i_mdb1GvYFZr1ZEqvCgZ3+um-ZYuz5xAFZuwjwBcXsEk3Q@mail.gmail.com>
	<54E5F77D.9090406@fischer.name>
	<CA+9eiLurXVtk0eKAuKF8uUb=6SVqZtatXSvZ9bnvW1gnb0hz4A@mail.gmail.com>
	<54E6F48A.9040906@fischer.name>
	<CAPwsocEiTSOM0EtFR52KNFCZNYG4dDguuyvNpk5kMKaRDwOZCA@mail.gmail.com>
	<CAL=_i_m4gUy081cMM4Aw5St4OYxVfAXK0hDZ_fSR-ChZc_UUow@mail.gmail.com>
	<54E72FE7.9030803@googlemail.com>
	<54E7312D.9090404@googlemail.com>
	<CAL=_i_m44Nbabgx56p_Lo9w5hCW-=MW3rvyh_2-B-bV7e3NkBQ@mail.gmail.com>
	<54E73E70.5020403@googlemail.com>
	<CAGa2bXZYipV0u2yOireZyrqoZY_z57cPtX_t-F6vaD3--e5U2Q@mail.gmail.com>
Date: Sat, 21 Feb 2015 09:53:51 -0800
Message-ID: <CAEZPtU7sJcfYGmZFwAO7tS+RbJafESRwU-jTPEV4_H_c8t39CA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Crypto Compress <cryptocompress@googlemail.com>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [VOTE] Expectations
From: pierre.php@gmail.com (Pierre Joye)

On Fri, Feb 20, 2015 at 7:10 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi Crypto,
>
> On Fri, Feb 20, 2015 at 11:02 PM, Crypto Compress <
> cryptocompress@googlemail.com> wrote:
>
>> AssertionExceptions are not intended to be caught, they are intended to be
>>> seen, in a specific environment.
>>>
>>
>> Joe, your argumentation is around how (not) to use exceptions. I can see
>> your point and it's valid.
>> My point is about not to implement exceptions at all.
>>
>> If exceptions are not intended to be caught, they don't need to be thrown
>> (even if the context is different).
>> If exceptions are not thrown and not caught, we can use "error" in dev and
>> some easing severity (warning, zero cost nothing) in prod.
>>
>> Freely adapted from Murphy: If assertion exception can be catched, it will
>> be even in production.
>
>
> Assertion is only for development and testing.
> We need errors or exceptions during development and testing, but
> not in production. Therefore, errors/exception should not be catched
> by code in general. Isn't assertion nature?
>
> I don't insist not to enable assertion in production environment.
> There might be software that needs extreme reliability and stability.
> For these softwares, it makes sense to enable assertions and catch
> errors/exceptions to do some cleanups.

This last paragraph makes me wonder why in the world assert in PHP is
still anything valid. If anything it should be removed, to be honest.

Which softwares do not require to be reliable and stable? Most if not
all PHP written software interact with external inputs, be from APIs
point of view or from actual users. Per se, they have to be validated
and errors handling is part of this validation.

I do see some values for asserts in unit tests, but that's pretty much
all I can think about it.

All in all, I stay with my initial comment, this RFC needs more
discussion and some other critical questions must be answered before
this RFC.

Cheers,
-- 
Pierre

@pierrejoye | http://www.libgd.org