Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83338
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.192.173 as permitted sender)
Message-ID: <54E77D2E.60407@lerdorf.com>
Date: Fri, 20 Feb 2015 10:30:06 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Anthony Ferrara <ircmaxell@gmail.com>, 
 Larry Garfield <larry@garfieldtech.com>
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <20150220170854.308596800F2@frontend2.nyi.internal> <CAAyV7nFuk+zuS3nMjf79ou0Rr9Qu20jEcE5=wFYiASV5NnYcQg@mail.gmail.com>
In-Reply-To: <CAAyV7nFuk+zuS3nMjf79ou0Rr9Qu20jEcE5=wFYiASV5NnYcQg@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="F06wX8BMws28RVakiR9GVCw5hwivu2owR"
Subject: Re: [PHP-DEV] Reviving scalar type hints
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--F06wX8BMws28RVakiR9GVCw5hwivu2owR
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/20/2015 09:39 AM, Anthony Ferrara wrote:
> I think if anything, the appearance of Hack (and its adoption) show
> that people want static typing, at least to some level...

To be perfectly transparent here though, you should mention that your
proposed RFC goes well beyond the strict typing that is in Hack because
in Hack the internal API is largely untyped while your proposal is to
default the entire internal API to strict types in strict mode. Also, in
Hack there is a distinction between the off-line hh_client type-checker
and the runtime.

Hack examples all using <?hh // strict

  echo number_format('1000');
  echo htmlspecialchars(1000);
  echo md5(1000);

These are all fine both as far as the type-checker is concerned as well
as the runtime, of course, but they are runtime fatals in your proposed R=
FC.

And if you only go by the runtime and ignore the out-of-band type
checker there are almost no strictness rules applied to the internal API
in Hack.

eg.  explode(0, 1000);

Here the hh_client type checker will complain that it is expecting
strings, but the runtime will run it nicely.

So when you say, and as I have heard other people say, that people want
Hack-like strict typing, you have to be a bit careful about what is
meant by that. Even in the cases where the internal API is typed in
Hack, it is still not a runtime fatal if they are called with the wrong
types. Now whether that is a good thing or not is debatable, of course,
my point is simply that if you are going to use Hack adoption as a sign
"that people want static typing" you should clearly explain that your
approach is quite different from what Hack is doing.

-Rasmus



--F06wX8BMws28RVakiR9GVCw5hwivu2owR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEUEARECAAYFAlTnfS4ACgkQlxayKTuqOuBRqwCWMSIAXDIaTEwITkZqutYuhPK/
kACeJY6KB1Un/930bPXUznYzngUM1g4=
=qk1e
-----END PGP SIGNATURE-----

--F06wX8BMws28RVakiR9GVCw5hwivu2owR--