Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83275
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.192.171 cause and error)
MIME-Version: 1.0
In-Reply-To: <CABBJUpca6qEuvAovgzGYeqfk5NMQuemAE436yeda-=W3F9GprA@mail.gmail.com>
References: <CAL=_i_mdb1GvYFZr1ZEqvCgZ3+um-ZYuz5xAFZuwjwBcXsEk3Q@mail.gmail.com>
	<CABBJUpca6qEuvAovgzGYeqfk5NMQuemAE436yeda-=W3F9GprA@mail.gmail.com>
Date: Fri, 20 Feb 2015 08:38:04 +0000
Message-ID: <CAL=_i_nnGLsweqqy2nS8i31EugwBbf1rkpzGcX_-anviBqfi7Q@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134259a99e885050f80f80d
Subject: Re: [PHP-DEV] [VOTE] Expectations
From: pthreads@pthreads.org (Joe Watkins)

--001a1134259a99e885050f80f80d
Content-Type: text/plain; charset=UTF-8

The custom exception must derive from AssertionException, so the same
optimization is possible.

Cheers
Joe

On Fri, Feb 20, 2015 at 8:28 AM, Xinchen Hui <laruence@php.net> wrote:

> Hey:
>
>
>
> On Thu, Feb 19, 2015 at 5:09 PM, Joe Watkins <pthreads@pthreads.org>
> wrote:
> > Morning internals,
> >
> >     The expectations RFC is now in voting phase:
> > https://wiki.php.net/rfc/expectations#vote
>
> sorry, the thread is too long to read.. I am not sure whether there
> was some similar opinion before..
>
> I voted without custom exception, that  is because.
>
> if all assertion exception is AssertException, then we can simply
> optimized them away while zend.assert is disabled..
>
> like:
>
>    try  {
>           foo();
>           bar();
>           assert();
>     } catch (AssertException $e) {
>          //these statements can be optimized away.
>     }
>
>  but with custom exception..
>
>     try {
>
>          sqllitefunc();   // no threw
>          sqllitefunc1(); //no threw
>          assert("", new SqlLiteException());
>      } catch (SqlliteException $e) {
>           //we are not sure maybe sqllitefunc can throw SqliteException.
>          // thus we can not optimized these statements ayway
>      }
>
> thanks
> >
> > Cheers
> > Joe
>
>
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>

--001a1134259a99e885050f80f80d--