Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83274
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAL=_i_mdb1GvYFZr1ZEqvCgZ3+um-ZYuz5xAFZuwjwBcXsEk3Q@mail.gmail.com>
References: <CAL=_i_mdb1GvYFZr1ZEqvCgZ3+um-ZYuz5xAFZuwjwBcXsEk3Q@mail.gmail.com>
Date: Fri, 20 Feb 2015 16:28:53 +0800
Message-ID: <CABBJUpca6qEuvAovgzGYeqfk5NMQuemAE436yeda-=W3F9GprA@mail.gmail.com>
To: Joe Watkins <pthreads@pthreads.org>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [VOTE] Expectations
From: laruence@php.net (Xinchen Hui)

Hey:



On Thu, Feb 19, 2015 at 5:09 PM, Joe Watkins <pthreads@pthreads.org> wrote:
> Morning internals,
>
>     The expectations RFC is now in voting phase:
> https://wiki.php.net/rfc/expectations#vote

sorry, the thread is too long to read.. I am not sure whether there
was some similar opinion before..

I voted without custom exception, that  is because.

if all assertion exception is AssertException, then we can simply
optimized them away while zend.assert is disabled..

like:

   try  {
          foo();
          bar();
          assert();
    } catch (AssertException $e) {
         //these statements can be optimized away.
    }

 but with custom exception..

    try {

         sqllitefunc();   // no threw
         sqllitefunc1(); //no threw
         assert("", new SqlLiteException());
     } catch (SqlliteException $e) {
          //we are not sure maybe sqllitefunc can throw SqliteException.
         // thus we can not optimized these statements ayway
     }

thanks
>
> Cheers
> Joe



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/