Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83242
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAyV7nFi14fW9YDjAXc+TDARsr9w0OeNdgy5FUjTFrFg_B_12Q@mail.gmail.com>
References: <CAF+90c-7w1fLqmffYvPRhmtt8rzESEpSmW8vfMD-YfLt1mG_8w@mail.gmail.com>
	<CAF+90c8NAROuCDgRajF4AN2oTc4fzmxTjtVC_OAQH=ZFm5N9Uw@mail.gmail.com>
	<CAAyV7nFi14fW9YDjAXc+TDARsr9w0OeNdgy5FUjTFrFg_B_12Q@mail.gmail.com>
Date: Fri, 20 Feb 2015 01:39:39 +0400
Message-ID: <CA+9eiLvqdEwFmm_HKJOTskFTSraAhAkQBMS_Qe5pT=Na0iyXkw@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf3071c7c0f22667050f77c5c7
Subject: Re: [PHP-DEV] Re: [RFC] Exceptions in the engine
From: dmitry@zend.com (Dmitry Stogov)

--20cf3071c7c0f22667050f77c5c7
Content-Type: text/plain; charset=UTF-8

On Thu, Feb 19, 2015 at 11:26 PM, Anthony Ferrara <ircmaxell@gmail.com>
wrote:

> Nikita (and all),
>
> >  * Subclassing: Should there be more specific subclasses of
> EngineException
> > for particular errors?
>
> I think there's an important case to be made here. I don't think every
> error belongs having its own subclass, but there are at least a few
> cases where it may make sense. This list is based off the current PR
> (1095) and should be seen as incomplete :
>
> 1. Argument Mismatch (not passing required parameter, passing invalid
> parameter, etc)
> 2. Parse Error (eval, etc) - note this appears to be implemented already
> 3. Methods On Non-Objects (call to a member function on null)
> 4. Call to undefined method (this should be a separate exception from ^^^)
>
> I also think it *may* be worth while splitting out Class not found and
> function not found exceptions into their own type, but not 100% sure.
>
>
Of course, we can add few subclasses of EngineException.

Thanks. Dmitry,


> Thanks
>
> Anthony
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--20cf3071c7c0f22667050f77c5c7--