Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83238
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c8NAROuCDgRajF4AN2oTc4fzmxTjtVC_OAQH=ZFm5N9Uw@mail.gmail.com>
References: <CAF+90c-7w1fLqmffYvPRhmtt8rzESEpSmW8vfMD-YfLt1mG_8w@mail.gmail.com>
	<CAF+90c8NAROuCDgRajF4AN2oTc4fzmxTjtVC_OAQH=ZFm5N9Uw@mail.gmail.com>
Date: Thu, 19 Feb 2015 15:26:49 -0500
Message-ID: <CAAyV7nFi14fW9YDjAXc+TDARsr9w0OeNdgy5FUjTFrFg_B_12Q@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Re: [RFC] Exceptions in the engine
From: ircmaxell@gmail.com (Anthony Ferrara)

Nikita (and all),

>  * Subclassing: Should there be more specific subclasses of EngineException
> for particular errors?

I think there's an important case to be made here. I don't think every
error belongs having its own subclass, but there are at least a few
cases where it may make sense. This list is based off the current PR
(1095) and should be seen as incomplete :

1. Argument Mismatch (not passing required parameter, passing invalid
parameter, etc)
2. Parse Error (eval, etc) - note this appears to be implemented already
3. Methods On Non-Objects (call to a member function on null)
4. Call to undefined method (this should be a separate exception from ^^^)

I also think it *may* be worth while splitting out Class not found and
function not found exceptions into their own type, but not 100% sure.

Thanks

Anthony