Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83118
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 209.85.212.176 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAB6YZuxcU+nfvd=WkM-CYNcO=g1yGxALrCPSP6Y2-p-k9PNenw@mail.gmail.com>
References: <CA+9eiLsxSpbdaa7Bpci2PRXQMRkTUiwZphjQYv2iDyXLUhrMow@mail.gmail.com>
	<CAEPJdukU+oWaH6jm=vk8chXbwUePsa3KPEXbgfx2BVxWBDbtig@mail.gmail.com>
	<CA+9eiLtJ+8UB8XhM8PFGtWtcUz015pnHJPVewVWy2xzdjk2Lxg@mail.gmail.com>
	<CAF+90c_h_rCDtaqOYgknc8kgF8ha487RNgQjFY-q6kUgJ8ijYA@mail.gmail.com>
	<CA+9eiLtEDdA=c=Ntc9UaBf5AgftxqcbOgVNgiKJiDb69Y1cyhA@mail.gmail.com>
	<CAF+90c-96WZbVJyU6XiOMvy6=A2QkRmTBCQ7-6Ds__96pHpozw@mail.gmail.com>
	<CA+9eiLtXWk=xFf1u1to1RKNHJf2tWSxYPuJJF70LBVmx9xGCpg@mail.gmail.com>
	<CAEbg-4aoz9fXVLjE6b7+UvBKmO7iNcN4j-K5pxQr7g2LcejkJQ@mail.gmail.com>
	<02a101d04af9$507484f0$f15d8ed0$@php.net>
	<CAFp73XvcT5usUM6xJFwZ2dD9ARW+wRnygf0X-kj+hWe_8KQZ7g@mail.gmail.com>
	<CA+9eiLtXd3_3TwU84HCcMeHqF_9toC7eH6j8bY63h4z=5gJrnw@mail.gmail.com>
	<CAEPJduk0BV4JsF7r3k-HCXD2Ec3rDLaqF8aMbVCnLfXo4BPCgg@mail.gmail.com>
	<02ff01d04b72$abae34a0$030a9de0$@php.net>
	<CA+9eiLu19ewy6vjR+Cf00rd3TFnUyG-0rKZWjb3aift+fjheRg@mail.gmail.com>
	<032801d04b8d$8ff3dce0$afdb96a0$@php.net>
	<CA+9eiLsRK6DQGPnY3B=uvcEYfF_gaSQ5OZUesf6+qe60m7t66w@mail.gmail.com>
	<CAFp73XtrJMLpfzJHQp+tGFWiqJ0HVVwakEXQiMFWkaVZANRxkg@mail.gmail.com>
	<CAB6YZuxcU+nfvd=WkM-CYNcO=g1yGxALrCPSP6Y2-p-k9PNenw@mail.gmail.com>
Date: Wed, 18 Feb 2015 21:45:55 +0100
Message-ID: <CAEPJdu=JEwAmh+i5f+OHbU1Au0LqDAmuh5gJorta+N4MwZs6_g@mail.gmail.com>
To: =?UTF-8?Q?Pavel_Kou=C5=99il?= <pajousek@gmail.com>
Cc: "guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>, Dmitry Stogov <dmitry@zend.com>, 
	francois <francois@php.net>, Alexander Lisachenko <lisachenko.it@gmail.com>, 
	Nikita Popov <nikita.ppv@gmail.com>, PHP Internals <internals@lists.php.net>, 
	Pierrick CHARRON <pierrick@webstart.fr>, Pierre Joye <pierre.php@gmail.com>, 
	Zeev Suraski <zeev@zend.com>, Andi Gutmans <andi@zend.com>, Joe Watkins <pthreads@pthreads.org>, 
	Yasuo Ohgaki <yohgaki@ohgaki.net>, Sebastian Bergmann <sebastian@php.net>, 
	Stanislav Malyshev <smalyshev@gmail.com>, Rasmus Lerdorf <rasmus@lerdorf.com>
Content-Type: multipart/alternative; boundary=047d7bd6adceeaa6ca050f62e730
Subject: Re: [PHP-DEV] Annotations in PHP7
From: kontakt@beberlei.de (Benjamin Eberlei)

--047d7bd6adceeaa6ca050f62e730
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 18, 2015 at 9:29 PM, Pavel Kou=C5=99il <pajousek@gmail.com> wro=
te:

> On Wed, Feb 18, 2015 at 7:28 PM, guilhermeblanco@gmail.com
> <guilhermeblanco@gmail.com> wrote:
> > Hi Dmitry,
> >
> >> Are you (and Doctrine team) interested in this annotation idea?
> >
> > I'd say that Benjamin nailed in our possible usage:
> >
> > <orm(new Entity("foo"))>
> > class Foo {
> > }
> >
> > Now I do feel we need to elaborate some sort of named parameters.
> Doctrine
> > tries to simplify a lot developer's life by using consistency in defaul=
t
> > mapping and only if the user wants to override default behavior he need=
s
> to
> > override a given parameter. This means in a case where you're mapping a
> > JoinColumn (
> >
> https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mappin=
g/JoinColumn.php
> > ),
> > you may only want to specify the onDelete=3D"CASCADE" operation instead=
 of
> > name, referencedColumnName and many other parameters.
> > Trying to map this in your default parameter passing, we'd have somethi=
ng
> > like:
> >
> > <orm(
> >     [
> >         new OneToOne("Address"),
> >         new JoinColumn(default, default, default, default, "CASCADE")
> >     ]
> > )>
> > public $address;
> >
> > As I said, named parameters make a lot of sense when mapping defaults.
> > Now by looking at this syntax, I still think we're closer to a simple
> array
> > implementation (ReflectionClass::getMetadata(string $name)) and having
> > something like:
> >
> > <[
> >     "orm" =3D> [
> >         new OneToOne("Address"),
> >         new JoinColumn(default, default, default, default, "CASCADE")
> >     ]
> > ]>
> > public $address;
> >
> >
> > PS: We haven't even started on talking about overrides yet... =3D\
> >
>
> As a Doctrine user, I find this way worse than current state. This
> syntax looks UGLY and contains a lot of useless clutter. And yeah,
> adding named parameters to PHP be pretty helpful to make annotations
> more readable. :(
>

This is in no way related, only by the choice of guilherme's syntax. You
could
pass an array of options to the constructor to simulate named easily.

>
> And to what Francois said ("Anyway, I don't like the OO features
> people want to add everywhere. They can get strings and inject them to
> OO, but that's not the role of the annotation layer, IMHO. I
> definitely prefer the KISS approach."). What's exactly wrong with
> doing annotations in an object oriented manner? Both Doctrine
> Annotations and C# have them as objects, and it works well. Having
> annotations as just array of expressions/strings/whatever and needing
> another library to parse them is not really that great "upgrade" from
> current state. :(
>

PHP is not primarily an OOP language. As a user of Doctrine you wouldn't
need to care,
because we would wrap it anyway in our current code. So it wouldn't matter.


>
> Regards
> Pavel Kouril
>

--047d7bd6adceeaa6ca050f62e730--