Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:83111
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEbg-4ZECDVkDQc=fcvz5FDJnRVJCTE4=8=GLG1AeHqkPMbB6w@mail.gmail.com>
References: <CAEbg-4aZytKiqG3Y5U-HrBMp2+JuGHu3UTOMLWiiUQn59FtpLw@mail.gmail.com>
	<CA+9eiLvkoTB2xdo4a6AdDnU8fjxOBbog+4FHm-UyBZzWNOQd4Q@mail.gmail.com>
	<CAF+90c8tSa640KrkzMk0kCE8x06m=y007u4zyB9_Zrh7vP3mJg@mail.gmail.com>
	<CAEbg-4ZoLQ_MKPz4b9PoCuLj5rBYBOnSbnF4c2PG4odV=Vv=Rg@mail.gmail.com>
	<CAF+90c-+zdywtuzVvpqxY_ZmrsAH++z5_kHMo9Lg1k_dJfYnMQ@mail.gmail.com>
	<CA+9eiLvVySGcxaB5q4a-tyUaKQE5wnv+asJni+s++BZXO5u+pg@mail.gmail.com>
	<CAEbg-4ZECDVkDQc=fcvz5FDJnRVJCTE4=8=GLG1AeHqkPMbB6w@mail.gmail.com>
Date: Wed, 18 Feb 2015 23:40:38 +0400
Message-ID: <CAEbg-4ZGLV8VnBe0Aya3XK-o5hT0o0eiAi95+b6dDqc0v2dKFQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Nikita Popov <nikic@php.net>, 
	PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bb03ea8736875050f61fe63
Subject: Re: [PHP-DEV] [RFC][Discussion] Parser extension API
From: lisachenko.it@gmail.com (Alexander Lisachenko)

--047d7bb03ea8736875050f61fe63
Content-Type: text/plain; charset=UTF-8

I want to attach a link to the Python AST documentation:
https://docs.python.org/3.2/library/ast.html
What I like there is iteration of nodes with generators (yields).
NodeVisitor that can be extended and used as coroutine to simplify logic of
traversal.

I want to keep Node class as simple DTO with public properties, but only
children field will be a generator.

What do you think?

2015-02-18 22:34 GMT+03:00 Alexander Lisachenko <lisachenko.it@gmail.com>:

>
> 2015-02-18 22:22 GMT+03:00 Dmitry Stogov <dmitry@zend.com>:
>
>> I think the AST API shouldn't use "public" properties.
>> Using it, we will have to construct the whole tree of objects,
>> duplicating information from AST.
>> I would propose SimpleXML approach instead - construct object only for
>> node(s) we currently access.
>
>
> What about Generators? They can be used nicely for handling AST data. And
> each node can be constructed as needed during the traversal. Probably this
> way is better than ArrayAccess
>

--047d7bb03ea8736875050f61fe63--